Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed outdated info in readme #969

Merged
merged 2 commits into from
Mar 21, 2023
Merged

Conversation

blaz-r
Copy link
Contributor

@blaz-r blaz-r commented Mar 18, 2023

Description

I fixed links in the readme that were not working.

  • Most of them were broken due to move of anomalib into src directory.
  • There was also a link to hardware section of the documentation that no longer exists so I changed that as well.
  • Since some of the links were relative and some used entire url, I also unified them all to be relative if referring to the file from the repository.

@github-actions github-actions bot added the Docs label Mar 18, 2023
@blaz-r
Copy link
Contributor Author

blaz-r commented Mar 18, 2023

Also fixed commands:

  • added src before anomalib in path
  • run in weight path
  • --meta_data changed to --metadata

@blaz-r blaz-r changed the title Fixed broken links in readme Fixed outdated info in readme Mar 18, 2023
Copy link
Contributor

@samet-akcay samet-akcay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @blaz-r

@blaz-r
Copy link
Contributor Author

blaz-r commented Mar 19, 2023

@samet-akcay one thing I noticed is that meta_data was changed to metadata, so I fixed that as I said before. But in version 4.0.0 there still is meta_data used.
Is my change correct to reflect the current state on main branch or should it be as it is v4.0.0?

@samet-akcay
Copy link
Contributor

it's correct. Those changes will be in effect in v0.5.0

@codecov
Copy link

codecov bot commented Mar 21, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (56706b3) 81.33% compared to head (eeb0b90) 81.33%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #969   +/-   ##
=======================================
  Coverage   81.33%   81.33%           
=======================================
  Files         176      176           
  Lines        6805     6805           
=======================================
  Hits         5535     5535           
  Misses       1270     1270           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@samet-akcay samet-akcay merged commit c92fb52 into openvinotoolkit:main Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants