-
Notifications
You must be signed in to change notification settings - Fork 709
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed openvino_inferencer in gradio_inference #972
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for addressing this
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #972 +/- ##
=======================================
Coverage 81.35% 81.35%
=======================================
Files 176 176
Lines 6802 6802
=======================================
Hits 5534 5534
Misses 1268 1268 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just realized that config
should be made optional then as it is not needed for openvino models. We can check against the extension type and assert if config
is not empty. Similarly, we should check whether the metadata is provided for the openvino inferencer.
This is a good idea yes. It should probably be implemented in a separate PR, or do you think it can be done in this one? |
Let's do this in this one just to make it complete. We need to add just two assert statements and remove the |
Good, I'll implement that and report back. |
@ashwinvaidya17 I implemented the changes required. Made config not required and added two checks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again
Description
Fixed OpenVINOInferencer instantiation in gradio_inference. OpenVINOInferencer now no longer takes config parameter. This was previously fixed in openvino_inference, but not in gradio_inference, so I fixed it here as well.
Changes
Checklist