-
Notifications
You must be signed in to change notification settings - Fork 709
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the new datamodule tests #973
Add the new datamodule tests #973
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the efforts. I have a few comments.
tests/unit/data/test_folder.py
Outdated
|
||
# Create and prepare the dataset | ||
_datamodule = Folder( | ||
root="./datasets/bottle", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should probably use get_dataset_path
for all the dataset tests. It would be a good idea in the future to make this a fixture instead of a method.
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## refactor/tests #973 +/- ##
===================================================
- Coverage 81.34% 16.92% -64.42%
===================================================
Files 176 176
Lines 6812 6812
===================================================
- Hits 5541 1153 -4388
- Misses 1271 5659 +4388
... and 153 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the efforts
Description
Changes
Checklist