Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the new datamodule tests #973

Merged

Conversation

samet-akcay
Copy link
Contributor

@samet-akcay samet-akcay commented Mar 20, 2023

Description

  • Add new datamodule tests.

Changes

  • Bug fix (non-breaking change which fixes an issue)
  • Refactor (non-breaking change which refactors the code base)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • My code follows the pre-commit style and check guidelines of this project.
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes
  • I have added a summary of my changes to the CHANGELOG (not for minor changes, docs and tests).

@github-actions github-actions bot added CI Dependencies Pull requests that update a dependency file Setup Tests labels Mar 20, 2023
Copy link
Collaborator

@ashwinvaidya17 ashwinvaidya17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the efforts. I have a few comments.

tox.ini Outdated Show resolved Hide resolved
tests/unit/data/base/test_image.py Outdated Show resolved Hide resolved
tests/unit/data/base/test_video.py Outdated Show resolved Hide resolved

# Create and prepare the dataset
_datamodule = Folder(
root="./datasets/bottle",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably use get_dataset_path for all the dataset tests. It would be a good idea in the future to make this a fixture instead of a method.

@codecov
Copy link

codecov bot commented Mar 22, 2023

Codecov Report

Patch coverage has no change and project coverage change: -64.42 ⚠️

Comparison is base (522858f) 81.34% compared to head (8f5f342) 16.92%.

Additional details and impacted files
@@                 Coverage Diff                 @@
##           refactor/tests     #973       +/-   ##
===================================================
- Coverage           81.34%   16.92%   -64.42%     
===================================================
  Files                 176      176               
  Lines                6812     6812               
===================================================
- Hits                 5541     1153     -4388     
- Misses               1271     5659     +4388     
Impacted Files Coverage Δ
src/anomalib/data/avenue.py 73.62% <ø> (+2.19%) ⬆️

... and 153 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@ashwinvaidya17 ashwinvaidya17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the efforts

@samet-akcay samet-akcay merged commit 7cbbd9d into openvinotoolkit:refactor/tests Mar 22, 2023
@samet-akcay samet-akcay deleted the refactor/sa/tests branch March 22, 2023 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Dependencies Pull requests that update a dependency file Setup Tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants