-
Notifications
You must be signed in to change notification settings - Fork 709
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor AUPRO metric #991
Refactor AUPRO metric #991
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #991 +/- ##
==========================================
+ Coverage 81.19% 81.32% +0.13%
==========================================
Files 176 176
Lines 6818 6813 -5
==========================================
+ Hits 5536 5541 +5
+ Misses 1282 1272 -10
... and 2 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This goes beyond the pure refactoring discussed here. To achieve the refactor:
- Remove
inspection_mask
(keep it in your private class that inherits fromAUPRO
) - Shift the flattening into
_compute
.
Doing so, you will be able to overload the __init__
and the _compute
functions when inheriting from AUPRO
and anomalib does not need to support masking.
@ORippler Got it, thank you a lot for the feedback! 😊 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for your contribution
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Description
Hi, this is a proposal PR for the disscusion here #974
inspection_mask
can be provided during initialization to filter out points outside the mask.Provide a summary of the modification as well as the issue that has been resolved. List any dependencies that this modification necessitates.
Changes
Checklist