-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to pyproject.toml for specifying dependencies #2052
Conversation
8117797
to
5661acd
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #2052 +/- ##
===========================================
+ Coverage 32.82% 32.97% +0.14%
===========================================
Files 476 475 -1
Lines 42278 42217 -61
===========================================
+ Hits 13879 13921 +42
+ Misses 28399 28296 -103
|
eedf2ab
to
cf7ab7c
Compare
In its current state, and with reference to the current state of OS distributions and Python build tools, this change breaks a lot. |
pyproject.toml is the future of the Python packaging, but we will only be able to do the switch once the distros we claim support for ship with setuptools/pip versions that do not exhibit breaking issues above. |
Changes
Most of the metadata has been moved out from setup.py to pyproject.toml.
Reason for changes
setup.py is increasingly deprecated, and tools turn to pyproject.toml for specifying dependencies and other static configuration. setup.py cannot be removed completely, though, at this time, since we use it for dynamic version generation (if installed from source) and there are no good and compatible alternatives for this.
Related tickets
N/A
Tests
install tests