Fix simd uni instructions for sse41 #149
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lohika-denis-kotov
force-pushed
the
fix/fix_simd_uni_instructions_for_sse41
branch
2 times, most recently
from
53fa0a4 to
44325d3
Compare
|
@ceciliapeng2011 @dmitry-gorokhov @maxnick Please, take a look or assign reviewers |
maxnick
approved these changes
Oct 13, 2022
|
@dmitry-gorokhov, could you please take a look? |
lohika-denis-kotov
force-pushed
the
fix/fix_simd_uni_instructions_for_sse41
branch
from
44325d3 to
551d001
Compare
lohika-denis-kotov
force-pushed
the
fix/fix_simd_uni_instructions_for_sse41
branch
from
551d001 to
a39dca1
Compare
…, uni_vminps and uni_vcmpps operations
lohika-denis-kotov
force-pushed
the
fix/fix_simd_uni_instructions_for_sse41
branch
from
a39dca1 to
b5a919f
Compare
|
@dmitry-gorokhov @nshchego @chenhu-wang Do you have some comments for this PR ? |
|
@dmitry-gorokhov @nshchego @chenhu-wang Do you have additional comments ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is fixing issues with sse41 for
uni_*operations.Consider the following example:
uni_vsubps(xmm_y0, xmm_pred_ctr_y, xmm_y0);, where
xmm_y0=xmm0,xmm_pred_ctr_y=xmm8Previously this example was converted on sse41 in wrong logical instructions:
As you can see, last instruction is logically wrong
addps(xmm0, xmm0);openvinoPR: openvinotoolkit/openvino#13472