Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CPU] Fix issues about incorrect use of rsp offset and register alias #161

Open
wants to merge 3 commits into
base: v2.7_for_ie_master
Choose a base branch
from
Open

[CPU] Fix issues about incorrect use of rsp offset and register alias #161

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
de8e2bb
[CPU] Fix incorrect offset to rsp
xuchen-intel Oct 31, 2022
448493a
[CPU] Fix reg_ch_blocks being messed by its alias
xuchen-intel Nov 9, 2022
09e977a
[CPU] Fix issue regarding pop vmm_mask in jit_uni_depthwise_injector
xuchen-intel Nov 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/cpu/x64/injectors/jit_uni_depthwise_injector.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,7 +255,7 @@ void jit_uni_depthwise_injector_f32<isa>::compute(int start_idx, int end_idx,
if (need_to_preserve) {
if (preserved_vecs_count > 1)
pop_vmm(h, vmm_aux0);
if (preserved_vecs_count > 1)
if (preserved_vecs_count > 0)
pop_vmm(h, vmm_mask);
}
}
Expand Down
2 changes: 1 addition & 1 deletion src/cpu/x64/jit_avx512_core_bf16_dw_conv_kernel.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -467,7 +467,7 @@ void jit_avx512_dw_conv_fwd_kernel_bf16::compute_loop(
pop(reg_output);
pop(reg_input);
pop(reg_kernel);
base_post_ops_data_offset -= reg64_size;
base_post_ops_data_offset -= 3 * reg64_size;

} else {
compute(ur_ch_blocks, masked_ch_block_tail);
Expand Down
2 changes: 1 addition & 1 deletion src/cpu/x64/jit_avx512_core_bf16_dw_conv_kernel.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ struct jit_avx512_dw_conv_fwd_kernel_bf16 : public jit_generator {
reg64_t iter_kh = rax;
reg64_t reg_oi = rbx;

reg64_t reg_tmp = reg_ch_blocks;
reg64_t reg_tmp = rbp;

// fused convolution
reg64_t reg_input_buffer_ptr = rdx;
Expand Down