ensure initial propmpt is long for perf metrics tests #1471
+3
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -586,7 +586,8 @@ def run_perf_metrics_collection(model_descr, generation_config: Dict, prompt: st | |||
| def test_perf_metrics(model_descr, generation_config, prompt): | |||
| import time | |||
| start_time = time.perf_counter() | |||
| perf_metrics = run_perf_metrics_collection(read_model(model_descr), generation_config, prompt) | |||
| # To ensure the prefill stage takes much more time make initial prompt long. | |||
| perf_metrics = run_perf_metrics_collection(read_model(model_descr), generation_config, prompt * 200) | |||
| total_time = (time.perf_counter() - start_time) * 1000 | |||
There was a problem hiding this comment.
in general, assumptions about perf metrics like assert load_time < 1000.0 should not be in tests, because depending on machine / network stability load_time may significantly vary
fixed it here #1478 (comment)
wutthichai46
approved these changes
Jan 4, 2025
| @@ -586,7 +586,8 @@ def run_perf_metrics_collection(model_descr, generation_config: Dict, prompt: st | |||
| def test_perf_metrics(model_descr, generation_config, prompt): | |||
| import time | |||
| start_time = time.perf_counter() | |||
| perf_metrics = run_perf_metrics_collection(read_model(model_descr), generation_config, prompt) | |||
| # To ensure the prefill stage takes much more time make initial prompt long. | |||
| perf_metrics = run_perf_metrics_collection(read_model(model_descr), generation_config, prompt * 200) | |||
There was a problem hiding this comment.
I suppose it's more clear to extend prompt where it's initially created:
(dict(max_new_tokens=20), 'table is made of' * 200),
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix test from #1414
Ticket CVS-155098