Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
【PaddlePaddle Hackathon 3】Add Paddle gather_nd operator #12355
【PaddlePaddle Hackathon 3】Add Paddle gather_nd operator #12355
Changes from 11 commits
e697e9d
49f3695
38304ba
849c78a
9617e15
b1b9bf6
0d0eb70
ed8e6ef
48897dc
9eac065
a72577d
607c45f
f1cfb79
13b7ebe
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As I see from the specification zero index is supported by gather ND op:
https://docs.openvino.ai/latest/openvino_docs_ops_movement_GatherND_8.html#doxid-openvino-docs-ops-movement-gather-n-d-8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, @ilyachur : thanks for taking your time to help have a look at this PR. the 'indices' input value of OV 'gather_nd' can be '0', but as its specification describes 'A tensor of a rank not less than 1'. the 'indices' input rank should not be '0'(@AndPuQing has created an commented test case 'gather_nd_empty' to cover this).
Maybe we should change it to the following way?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes I think it will be more aligned with the specification