[GSoC] 237 - Typo Detection #908

Ravindu987 · 2023-03-13T17:46:38Z

As per the prerequisite task assigned to me for GSoC '23 (#832), I have added the implementation of HuggingFace Typo Detection model with OpenVINO.
The newly added notebook provides a comprehensive guide for the above implementation in two methods.

Since there is a PR for 236 (#902) , I chose 237 as the number for this notebook.

review-notebook-app · 2023-03-13T17:46:43Z

Check out this pull request on

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

Ravindu987 · 2023-03-14T10:37:45Z

It seems that docker_nbval check is failing for notebooks 211 and 215. I noticed this happens in other PR as well. Is there something I can do about this?

Also please let me know if there are any ideas for further improvement in this notebook.

adrianboguszewski · 2023-03-14T12:03:59Z

It seems that docker_nbval check is failing for notebooks 211 and 215. I noticed this happens in other PR as well. Is there something I can do about this?

Also please let me know if there are any ideas for further improvement in this notebook.

We have created a PR (#910) with the fix. Please rebase your PR when it's merged.

Ravindu987 · 2023-03-14T13:56:05Z

It seems that docker_nbval check is failing for notebooks 211 and 215. I noticed this happens in other PR as well. Is there something I can do about this?
Also please let me know if there are any ideas for further improvement in this notebook.

We have created a PR (#910) with the fix. Please rebase your PR when it's merged.

Noted with thanks.

notebooks/238-typo-detector/README.md

notebooks/238-typo-detector/238-typo-detector.ipynb

Co-authored-by: Zhuo Wu <[email protected]>

zhuo-yoyowz · 2023-05-11T02:46:49Z

Please update your branch to notebook main and pass all CI. Then we can assign your notebook to final round of review. Thanks~

Ravindu987 · 2023-05-15T11:19:34Z

Please update your branch to notebook main and pass all CI. Then we can assign your notebook to final round of review. Thanks~

Thanks for the reply @zhuo-yoyowz The build fails on Python 3.9 in CI tests because the xml file can't be read by the runtime core. I've check this locally and it works. Any idea what might cause this

adrianboguszewski · 2023-07-03T14:06:46Z

@Ravindu987, this is great work. Please restore changes in the main README, solve conflicts and change the number to 243 and I'll merge it :)

notebooks/238-typo-detector/238-typo-detector.ipynb

eaidova · 2023-07-03T14:20:22Z

notebooks/238-typo-detector/238-typo-detector.ipynb

@@ -0,0 +1,583 @@
+{


it is preferred to use python API for Model Optimizer then CLI, could you please convert model using this way?
see https://docs.openvino.ai/2023.0/openvino_docs_MO_DG_Deep_Learning_Model_Optimizer_DevGuide.html for details

Reply via ReviewNB

Done. Please check

eaidova · 2023-07-03T14:20:22Z

notebooks/238-typo-detector/238-typo-detector.ipynb

@@ -0,0 +1,583 @@
+{


it is perfect, but you do not uses Infer Request directly in code below, so description is not complete or does not correspond of your inference way

Reply via ReviewNB

Updated the description. Earlier I used Infer requests and when I changed it I forgot to update the description. Sorry about that. Please check now.

Ravindu987 · 2023-07-20T09:24:10Z

Hi all,
Sorry for the delay as I had exams in the past couple of weeks. I resolved the merge conflicts and made the changes requested by @eaidova Please check those
@adrianboguszewski Since 243 is already taken, I used the next available number 245. I hope its ok

Ravindu987 · 2023-08-05T11:09:26Z

Hi all,
The spell-check test fails because of the variable names and imported module names.
After merging the latest commits, the docker test also fails as it can't import the OVModelForTokenClassification module from the optimum.intel.openvino library. Can I do something regarding this.
Please let me know

eaidova · 2023-08-07T04:48:35Z

Hi all, The spell-check test fails because of the variable names and imported module names. After merging the latest commits, the docker test also fails as it can't import the OVModelForTokenClassification module from the optimum.intel.openvino library. Can I do something regarding this. Please let me know

@Ravindu987, please round variables names in `` tag and install optimum intel inside notebook, you can check as example
https://github.com/openvinotoolkit/openvino_notebooks/blob/main/notebooks/244-named-entity-recognition/244-named-entity-recognition.ipynb

P.S. do not worry, I do it for you

Ravindu987 · 2023-08-17T12:24:27Z

Thank you for the help, everyone. I would be pleased to contribute more. Please let me know if there are any other such needs. In the meantime I'll keep an eye on issues and try to contribute towards them.

adrianboguszewski added new notebook new jupyter notebook gsoc Google Summer of Code (Prerequisite Task) labels Mar 14, 2023

adrianboguszewski requested a review from zhuo-yoyowz March 14, 2023 12:02

Ravindu987 and others added 23 commits March 14, 2023 20:14

Introduction

0e12629

Using optimum

bbc8b1c

Added torch-onnx-openvino convertion and run

cee9f28

Description updates

7f76375

Code adjustment

0f26c55

Add readme file

ab3ef5e

Update README.md

de1f345

Update README.md

479670f

Update README.md

5dba0d8

Update README.md

f809155

Update README.md

2b49c3b

Formatting

9551fee

Formatting

8f29ee4

Formatting

ca9a1ff

Formatting

62b22d1

Update nbval.yml

faf44e5

Formatting

acdd88c

Formatting

10502b0

Formatting

fb898e5

Formatting

43cb92c

Added descriptions

7e70863

Restore nbval.yml

59836fc

Added resulting list iteration

2093788

zhuo-yoyowz reviewed May 10, 2023

View reviewed changes

notebooks/238-typo-detector/README.md Outdated Show resolved Hide resolved

notebooks/238-typo-detector/238-typo-detector.ipynb Outdated Show resolved Hide resolved

Ravindu987 and others added 2 commits May 10, 2023 16:58

Update notebooks/238-typo-detector/README.md

918e34d

Co-authored-by: Zhuo Wu <[email protected]>

Update notebooks/238-typo-detector/238-typo-detector.ipynb

1650d81

Co-authored-by: Zhuo Wu <[email protected]>

Ravindu987 and others added 2 commits May 11, 2023 21:25

Merge branch 'main' into main

70ac085

Update description

fdd134c

zhuo-yoyowz self-requested a review May 15, 2023 12:37

zhuo-yoyowz approved these changes May 15, 2023

View reviewed changes

zhuo-yoyowz added tech_review: ready Ready for technical review and removed RFR2 Ready for review labels May 15, 2023

adrianboguszewski requested a review from eaidova May 15, 2023 14:27

adrianboguszewski self-requested a review July 3, 2023 11:08

eaidova reviewed Jul 3, 2023

View reviewed changes

Ravindu987 added 5 commits July 20, 2023 12:37

Merge upstream

b2ed385

Change notebook number and add -q to dependency

3e9e231

Replace CLI with Python API for Model Optimizer

f4f2543

Correct description regarding inference

63f7435

Add notebook to Readme

d6a2950

Ravindu987 force-pushed the main branch from 4a190b8 to d6a2950 Compare July 20, 2023 09:16

Ravindu987 and others added 3 commits July 20, 2023 14:56

Fix notebook readme link in the main readme

9b1b77e

Fix spelling errors

6757868

Merge branch 'main' into main

61173bb

eaidova approved these changes Aug 7, 2023

View reviewed changes

eaidova merged commit 0c30351 into openvinotoolkit:main Aug 7, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[GSoC] 237 - Typo Detection #908

[GSoC] 237 - Typo Detection #908

Ravindu987 commented Mar 13, 2023

review-notebook-app bot commented Mar 13, 2023

Ravindu987 commented Mar 14, 2023

adrianboguszewski commented Mar 14, 2023

Ravindu987 commented Mar 14, 2023

zhuo-yoyowz commented May 11, 2023

Ravindu987 commented May 15, 2023

adrianboguszewski commented Jul 3, 2023 •

edited

Loading

eaidova Jul 3, 2023 •

edited

Loading

Ravindu987 Jul 20, 2023

eaidova Jul 3, 2023 •

edited

Loading

Ravindu987 Jul 20, 2023

Ravindu987 commented Jul 20, 2023

Ravindu987 commented Aug 5, 2023

eaidova commented Aug 7, 2023 •

edited

Loading

Ravindu987 commented Aug 17, 2023

[GSoC] 237 - Typo Detection #908

[GSoC] 237 - Typo Detection #908

Conversation

Ravindu987 commented Mar 13, 2023

review-notebook-app bot commented Mar 13, 2023

Ravindu987 commented Mar 14, 2023

adrianboguszewski commented Mar 14, 2023

Ravindu987 commented Mar 14, 2023

zhuo-yoyowz commented May 11, 2023

Ravindu987 commented May 15, 2023

adrianboguszewski commented Jul 3, 2023 • edited Loading

eaidova Jul 3, 2023 • edited Loading

Choose a reason for hiding this comment

Ravindu987 Jul 20, 2023

Choose a reason for hiding this comment

eaidova Jul 3, 2023 • edited Loading

Choose a reason for hiding this comment

Ravindu987 Jul 20, 2023

Choose a reason for hiding this comment

Ravindu987 commented Jul 20, 2023

Ravindu987 commented Aug 5, 2023

eaidova commented Aug 7, 2023 • edited Loading

Ravindu987 commented Aug 17, 2023

adrianboguszewski commented Jul 3, 2023 •

edited

Loading

eaidova Jul 3, 2023 •

edited

Loading

eaidova Jul 3, 2023 •

edited

Loading

eaidova commented Aug 7, 2023 •

edited

Loading