Create working Windows and Linux release using Github Actions #21
Conversation
ArendJanKramer
force-pushed
the
arendjan/test
branch
from
26cfd21 to
a7f7b7d
Compare
| "HTTPS_PROXY": "http://proxy-dmz.intel.com:912", | ||
| }, | ||
| # env = { | ||
| # "HTTP_PROXY": "http://proxy-dmz.intel.com:911", |
There was a problem hiding this comment.
It's a public repo, should we remove that entirely?
| # Step 7: Set up Bazel environment variables | ||
| - name: Set up Bazel environment variables | ||
| env: | ||
| BAZEL_VC: C:\Program Files (x86)\Microsoft Visual Studio\2019\BuildTools\VC |
There was a problem hiding this comment.
Looks like it's static, can variable steup be done in job env vars declaration?
There was a problem hiding this comment.
Yes I can do that indeed, I chose to do it like this because Bazel doesn't exist before step 6 but in this case it doesn't matter I think
| - uses: subosito/flutter-action@v2 | ||
| with: | ||
| channel: 'stable' | ||
| flutter-version: '3.24.0' |
There was a problem hiding this comment.
You can use flutter version from pubspec file here
There was a problem hiding this comment.
Yes and no, this is a premade github actions. So I'm not sure how to extract that from pubspec and inject here
| - name: Build artifacts | ||
| run: flutter build windows --release | ||
| - name: Archive Release artifact | ||
| uses: thedoctor0/zip-release@master |
There was a problem hiding this comment.
What the difference between this and softprops/action-gh-release@v1 used later? Why this action does not have ref check if: startsWith(github.ref, 'refs/tags/')?
There was a problem hiding this comment.
The last stage is for releases, the page on Github where users can download our versions. These stages are for making artifacts on the Github actions build output page.
|
Closed as we moved to 24.5 |
No description provided.