General fixes & OpenVINO 24.6 RC3 #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Video is loaded when going back from metrics too
Subtitles and seeking from transcription is not working yet. Need to restructure the components a bit for that
For windows this should cover all cases
This should work in tandem with win_video_player. Another solution is needed for linux however
macos has its own buttons, but windows and linux use same button to control
Previously this was .go(). This was done to fix the providers to properly dispose. This was not neccesary. The main navigation buttons need to .go(), but others can keep stack just fine. Also added a dialog for when closing during download to make it clear to the user that download is stopped.
RHeckerIntel
requested review from
ArendJanKramer,
ActiveChooN and
AlexanderBarabanov
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #67 +/- ##
==========================================
+ Coverage 32.72% 32.79% +0.06%
==========================================
Files 38 38
Lines 1476 1476
==========================================
+ Hits 483 484 +1
+ Misses 993 992 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry for putting it in one PR.
Move to OpenVINO 24.6 rc3
Fix filter to use text-to-image instead of textToImage
Change routing to use push and pop
Previously this was .go(). This was done to fix the providers to
properly dispose.
This was not neccesary. The main navigation buttons need to .go(), but
others can keep stack just fine.
Also added a dialog for when closing during download to make it clear to
the user that download is stopped:
Use window manager to hide header and show our own:
