Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Dreamshaper to manifest, fix manifest scripts #74

Merged
merged 4 commits into from
Dec 19, 2024

Conversation

ArendJanKramer
Copy link
Collaborator

Update create_manifest.dart to recursively scan for filesizes in public models, and to use api instead of html parser.
Flip default RGB/BGR for TTI

Unfortunately, there's no collection yet for image generation by openvino. I made my own, and a small adjustment to make the code work with foreign collections.

Update create_manifest.dart to recursively scan for filesizes in public models, and to use api instead of html parser.
Flip default RGB/BGR for TTI
@ArendJanKramer ArendJanKramer force-pushed the arendjan/last_tti_fixes branch from 7d2e95c to 6e45bf0 Compare December 19, 2024 12:10
Copy link

codecov bot commented Dec 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 33.35%. Comparing base (04b2ea8) to head (216742d).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #74   +/-   ##
=======================================
  Coverage   33.35%   33.35%           
=======================================
  Files          39       39           
  Lines        1493     1493           
=======================================
  Hits          498      498           
  Misses        995      995           
Flag Coverage Δ
unittests 33.35% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@Radwan-Ibrahim Radwan-Ibrahim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor comments

assets/manifest.json Outdated Show resolved Hide resolved
assets/manifest.json Show resolved Hide resolved
assets/manifest.json Show resolved Hide resolved
assets/manifest.json Show resolved Hide resolved
lib/public_models.dart Outdated Show resolved Hide resolved
assets/manifest.json Outdated Show resolved Hide resolved
scripts/create_manifest.dart Show resolved Hide resolved
scripts/create_manifest.dart Show resolved Hide resolved
@ArendJanKramer ArendJanKramer merged commit 2830087 into main Dec 19, 2024
11 checks passed
@ArendJanKramer ArendJanKramer deleted the arendjan/last_tti_fixes branch December 19, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants