Update macOS icons and add app category to Info.plist #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArendJanKramer
requested review from
RHeckerIntel,
ActiveChooN and
AlexanderBarabanov
as code owners
ArendJanKramer
commented
Dec 20, 2024
| @@ -28,5 +28,7 @@ | |||
| <string>MainMenu</string> | |||
| <key>NSPrincipalClass</key> | |||
| <string>NSApplication</string> | |||
| <key>LSApplicationCategoryType</key> | |||
There was a problem hiding this comment.
I swear the indentation is correct in both intellij and xcode. I used xcode plist editor for the editing
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #80 +/- ##
=======================================
Coverage 33.33% 33.33%
=======================================
Files 39 39
Lines 1494 1494
=======================================
Hits 498 498
Misses 996 996
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.