Arendjan/vlm #84
Arendjan/vlm #84
Conversation
ArendJanKramer
requested review from
RHeckerIntel,
ActiveChooN and
AlexanderBarabanov
as code owners
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
license-eye has checked 469 files.
| Valid | Invalid | Ignored | Fixed |
|---|---|---|---|
| 206 | 3 | 260 | 0 |
Click to see the invalid file list
- lib/pages/vlm/widgets/image_grid.dart
- openvino_bindings/src/vlm/load_image.cpp
- openvino_bindings/src/vlm/load_image.hpp
Use this command to fix any missing license headers
```bash
docker run -it --rm -v $(pwd):/github/workspace apache/skywalking-eyes header fix
</details>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #84 +/- ##
==========================================
- Coverage 33.33% 32.22% -1.11%
==========================================
Files 39 42 +3
Lines 1494 1747 +253
==========================================
+ Hits 498 563 +65
- Misses 996 1184 +188
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
license-eye has checked 464 files.
| Valid | Invalid | Ignored | Fixed |
|---|---|---|---|
| 202 | 2 | 260 | 0 |
Click to see the invalid file list
- lib/pages/text_to_image/widgets/assistant_message.dart
- lib/pages/text_to_image/widgets/user_message.dart
Use this command to fix any missing license headers
```bash
docker run -it --rm -v $(pwd):/github/workspace apache/skywalking-eyes header fix
</details>
| const auto t2 = std::chrono::steady_clock::now(); | ||
|
|
||
| const auto generate_time = std::chrono::duration_cast<std::chrono::milliseconds>(t2 - t1).count(); | ||
|
|
||
| const auto load_time_f = static_cast<float>(load_time); | ||
| const auto generate_time_f = static_cast<float>(generate_time); | ||
| auto metrics = convertToVLMMetricsStruct(results.perf_metrics); | ||
| metrics.generate_time = generate_time_f; | ||
| metrics.load_time = load_time_f; |
There was a problem hiding this comment.
Can we check with OV team why metrics are not correct? Perhaps newer OpenVINO version could fix this?
There was a problem hiding this comment.
yes will check with them
No description provided.