Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add h-cls label info normalization #4173

Merged
merged 4 commits into from
Jan 9, 2025

Conversation

sovrasov
Copy link
Contributor

@sovrasov sovrasov commented Jan 7, 2025

Summary

Since OV doesn't allow serialization of lists of strings with spaces in rt_info, we need to serialize it on export.
Previously, only label names were normalized, now we're normalizing also h_cls info to avoid errors in MAPI wrapper.

How to test

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have ran e2e tests and there is no issues.
  • I have added the description of my changes into CHANGELOG in my target branch (e.g., CHANGELOG in develop).​
  • I have updated the documentation in my target branch accordingly (e.g., documentation in develop).
  • I have linked related issues.

License

  • I submit my code changes under the same Apache License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2025 Intel Corporation
# SPDX-License-Identifier: Apache-2.0

@github-actions github-actions bot added the TEST Any changes in tests label Jan 7, 2025
@sovrasov
Copy link
Contributor Author

sovrasov commented Jan 8, 2025

Ready for review, validated in Geti

@github-actions github-actions bot added the DOC Improvements or additions to documentation label Jan 8, 2025
Copy link
Collaborator

@atwinand atwinand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@kprokofi kprokofi merged commit b9debee into openvinotoolkit:develop Jan 9, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DOC Improvements or additions to documentation TEST Any changes in tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants