Merge pull request #2240 from sicpa-dlab/fix/did-exchange-cache

fix: only cache completed connection targets

aries_cloudagent/protocols/connections/v1_0/manager.py

@@ -1088,7 +1088,13 @@ async def get_connection_targets(
 
                     targets = await self.fetch_connection_targets(connection)
 
-                    await entry.set_result([row.serialize() for row in targets], 3600)
+                    if connection.state == ConnRecord.State.COMPLETED.rfc160:
+                        # Only set cache if connection has reached completed state
+                        # Otherwise, a replica that participated early in exchange
+                        # may have bad data set in cache.
+                        await entry.set_result(
+                            [row.serialize() for row in targets], 3600
+                        )
         else:
             targets = await self.fetch_connection_targets(connection)
         return targets