fix: public did mediator routing keys as did keys #1977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Squash of multiple commits: fix: revert changes to manager fix: don't use dereference_as fix: correct typo in method fix: remove stray print statement Signed-off-by: Daniel Bluhm <[email protected]>
|
@cjhowland and I need to add unit tests to this PR ensuring we've got coverage of the added lines. We also need to ensure that if the resolved routing key value is a did:key but not a did:key URL that we perform an appropriate transformation. |
Signed-off-by: Char Howland <[email protected]>
Signed-off-by: Char Howland <[email protected]>
Signed-off-by: Char Howland <[email protected]>
Signed-off-by: Char Howland <[email protected]>
Signed-off-by: Char Howland <[email protected]>
…-keys Fix/public did mediator routing keys
Signed-off-by: Daniel Bluhm <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #1977 +/- ##
==========================================
- Coverage 93.51% 93.51% -0.01%
==========================================
Files 539 539
Lines 34600 34615 +15
==========================================
+ Hits 32355 32369 +14
- Misses 2245 2246 +1 |
ianco
previously approved these changes
Oct 25, 2022
Signed-off-by: Char Howland <[email protected]>
Signed-off-by: Char Howland <[email protected]>
…-keys fix: account for changes to KeyType
|
Is this finished testing? |
Signed-off-by: Char Howland <[email protected]>
…-keys fix: black code formatter
|
@andrewwhitehead yes, this is ready for review |
ianco
approved these changes
Jan 5, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue @reflectivedevelopment found while using the recent changes made to support routing keys associated with public DID endpoints.
Without this fix, when creating a public DID OOB invitation, creation will fail due to no DIDComm service being found. This stemmed from PyDID expecting that routing keys be expressed strictly as DID URLs. Previously, we were resolving the routing keys as raw base58 encoded public keys. This PR makes it so that routing keys are resolved as did:key url values (if already did:key, simply pass through the values but if not, transform into did:key urls).
Credit to @cjhowland for doing most of the digging on this issue 🙂