Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

👷Publish aries-cloudagent-bbs Docker image #3175

Merged
merged 1 commit into from
Aug 16, 2024
Merged

👷Publish aries-cloudagent-bbs Docker image #3175

merged 1 commit into from
Aug 16, 2024

Conversation

rblaine95
Copy link
Contributor

@rblaine95
Publish aries-cloudagent-bbs Docker image
fd7e5d6 
* Resolves #3174

Signed-off-by: Robbie Blaine <[email protected]>
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@rblaine95 rblaine95 mentioned this pull request Aug 16, 2024
Closed
@jamshale jamshale requested a review from amanji August 16, 2024 22:06
amanji
amanji reviewed Aug 16, 2024
View reviewed changes
Copy link
Contributor

@amanji amanji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It LGTM but I'll defer to @esune or @WadeBarnes to give the thumbs up

jamshale
jamshale approved these changes Aug 16, 2024
View reviewed changes
Copy link
Contributor

@jamshale jamshale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Surprised we missed this. Thanks for catching it. Looks good 👍

@rblaine95
Copy link
Contributor Author

@jamshale I should have caught it in #3171, thank you for being so quick to review 🙌

@jamshale
Copy link
Contributor

Will merge after integration tests.

@swcurran
Copy link
Contributor

So what is the impact of this going on after 1.0.0? Any concerns?

@jamshale
Copy link
Contributor

I don't have any concerns. Doesn't affect any of the source code. We'll want to make sure the image is correct if it has been overridden by the bbs currently.

@jamshale jamshale merged commit 29583ac into openwallet-foundation:main Aug 16, 2024
8 checks passed
@jamshale
Copy link
Contributor

That might involve deleting the current image and re-running the workflow. I'm not exactly sure.

@rblaine95 rblaine95 deleted the patch-1 branch August 16, 2024 22:36
@rblaine95
Copy link
Contributor Author

rblaine95 commented Aug 16, 2024 •
edited
Loading

@jamshale running the workflow manually and specifying the tag as 1.0.0 will overwrite the existing 1.0.0 image without having to do another release

image

@jamshale
Copy link
Contributor

Going to do that now.

@rblaine95
Copy link
Contributor Author

Ah, that 403 error, I've seen that happen if it's the first time a package is being pushed.
Rerunning the workflow should resolve it.

@jamshale
Copy link
Contributor

I've seen that too. Didn't know re-running it worked.

@rblaine95
Copy link
Contributor Author

We (DIDx) had it happen a few times, especially when creating a large number of new packages in a single workflow run.

I think it's a hiccough with the Github API trying to provision new packages... some inconsistent backend state, something async that took just a little too long after creating the new package but before the permissions were configured in time 🤷

@jamshale
Copy link
Contributor

Looks like it's published now 👍

rngadam pushed a commit to rngadam/aries-cloudagent-python that referenced this pull request Aug 20, 2024
@rblaine95 @rngadam
Publish aries-cloudagent-bbs Docker image (openwallet-foundation#3175)
7731be7 
* Resolves openwallet-foundation#3174

Signed-off-by: Robbie Blaine <[email protected]>
jamshale pushed a commit to jamshale/acapy that referenced this pull request Aug 22, 2024
@rblaine95 @jamshale
Publish aries-cloudagent-bbs Docker image (openwallet-foundation#3175)
1e50530 
* Resolves openwallet-foundation#3174

Signed-off-by: Robbie Blaine <[email protected]>
Signed-off-by: jamshale <[email protected]>
ff137 pushed a commit to didx-xyz/acapy that referenced this pull request Aug 29, 2024
@rblaine95 @ff137
Publish aries-cloudagent-bbs Docker image (openwallet-foundation#3175)
38ab003 
* Resolves openwallet-foundation#3174

Signed-off-by: Robbie Blaine <[email protected]>
darshilnb pushed a commit to Northern-Block/aries-cloudagent-python that referenced this pull request Sep 5, 2024
@rblaine95 @darshilnb
Publish aries-cloudagent-bbs Docker image (openwallet-foundation#3175)
aa225e6 
* Resolves openwallet-foundation#3174

Signed-off-by: Robbie Blaine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amanji amanji amanji left review comments

@jamshale jamshale jamshale approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BBS enabled docker image overwrites normal image
4 participants
@rblaine95 @jamshale @swcurran @amanji