fix: anoncreds revocation notification when revoking #3226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thiago Romano <[email protected]>
|
jamshale
approved these changes
Sep 11, 2024
There was a problem hiding this comment.
I'm not sure how this got messed up because it's in the correct order for non-anoncreds, and looks like it's always been this way.
A side note. This scenario should get a new scenario integration test. I'm going to create a ticket for it. This should be tested with automated testing.
Thanks for fixing it. Your fix makes sense.
|
@jamshale , can you merge this? I don't have permission on this repo |
ff137
pushed a commit
to ff137/acapy
that referenced
this pull request
Oct 22, 2024
…dation#3226) Signed-off-by: Thiago Romano <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When revoking a credential using anoncreds, if you set
publish: trueandnotify:true, it wasn't sending the notification to the holder, because the publish part was happening before the notification "enqueue" part. Changing the order of things fixes the problem.