-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vim: Bump to 9.1.0888 #25450
base: master
Are you sure you want to change the base?
vim: Bump to 9.1.0888 #25450
Conversation
Wait, I didn't fix the hash |
e2dc692
to
36918f7
Compare
I removed some weird new lines... Not mentioning this the commit message. I noticed |
Also I suggest that we may introduce a breaking change:
Need discussions. |
It might be a good idea to sync vimrc.full with defaults.vim from upstream |
Use release tarballs from Github tags, because mirror sites are still on 9.0. Add help messages for packages. Refresh patch: - 010-no-msgfmt.patch - 002-remove_helptags_generation.patch Signed-off-by: Ryan Keane <[email protected]>
36918f7
to
e6ff9c1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Improving help/description should be in different commit.
PKG_SOURCE:=$(PKG_NAME)-$(PKG_VERSION).tar.bz2 | ||
PKG_SOURCE_URL:=http://ftp.vim.org/pub/vim/unix | ||
PKG_HASH:=a6456bc154999d83d0c20d968ac7ba6e7df0d02f3cb6427fb248660bacfb336e | ||
PKG_SOURCE:=v$(PKG_VERSION).tar.gz |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please dont do this. We can not download tarball named like this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did noticed this.. it will create a tarball named like v9.1.0888.tar.gz
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/openwrt/openwrt/blob/main/scripts/download.pl
No, I cant deal with it, why PKG_SOURCE:=foobar
PKG_SOURCE_URL:=https://foobar
will download tarball from https://foobar/foobar
, whyyyyy...
Use release tarballs from Github tags, because mirror sites are still on 9.0.
Refresh patch:
Maintainer: @ratkaj but he has not been active for 2 years...
Compile tested: bcm2711 341cc047b9174280d89f1b5494a42837ccbadb12
Run tested: not yet
Description:
Why using tarballs from tags? Because
9.0
was released 2 years ago, and the Vim website itself is distributing9.1
binary packages...They also placed a
9.1
tarball at https://www.vim.org/downloads/vim-9.1.tar.bz2 but not the mirror sites.Ubuntu 24.04 is on
9.1.0496
, Debian 12 is on9.0
9.1 supports XDG standard!
A question: Why do we need this patch 002-remove_helptags_generation.patch
R.I.P Bram Moolenaar you saved me from Visual Studio nightmare... and thanks all Neovim developers