Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vim: Bump to 9.1.0888 #25450

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

Ra2-IFV
Copy link
Contributor

@Ra2-IFV Ra2-IFV commented Nov 26, 2024

Use release tarballs from Github tags, because mirror sites are still on 9.0.
Refresh patch:

  • 002-remove_helptags_generation.patch

Maintainer: @ratkaj but he has not been active for 2 years...
Compile tested: bcm2711 341cc047b9174280d89f1b5494a42837ccbadb12
Run tested: not yet

Description:
Why using tarballs from tags? Because 9.0 was released 2 years ago, and the Vim website itself is distributing 9.1 binary packages...
They also placed a 9.1 tarball at https://www.vim.org/downloads/vim-9.1.tar.bz2 but not the mirror sites.
Ubuntu 24.04 is on 9.1.0496, Debian 12 is on 9.0
9.1 supports XDG standard!

A question: Why do we need this patch 002-remove_helptags_generation.patch

R.I.P Bram Moolenaar you saved me from Visual Studio nightmare... and thanks all Neovim developers

@Ra2-IFV
Copy link
Contributor Author

Ra2-IFV commented Nov 26, 2024

Wait, I didn't fix the hash
Also I want to add basic helps for packages

@Ra2-IFV Ra2-IFV force-pushed the feat_vim_update-9.1 branch from e2dc692 to 36918f7 Compare November 26, 2024 13:24
@Ra2-IFV
Copy link
Contributor Author

Ra2-IFV commented Nov 26, 2024

I removed some weird new lines... Not mentioning this the commit message.

I noticed Build/Compile/vim-help is implicit defined in Build/Compile/vim-runtime:
Build/Compile/vim-runtime creates a tar archive that includes files only for vim-help.
I think we have a better practice for this?

@Ra2-IFV
Copy link
Contributor Author

Ra2-IFV commented Nov 26, 2024

Also I suggest that we may introduce a breaking change:

Old New Description
/ vim META package for templating
vim vim-tiny --with-features=tiny
/ vim-small --with-features=small
vim-full vim-normal --with-features=normal
vim-fuller vim-big --with-features=big
/ vim-huge --with-features=huge

Need discussions.

@Ra2-IFV
Copy link
Contributor Author

Ra2-IFV commented Nov 28, 2024

It might be a good idea to sync vimrc.full with defaults.vim from upstream

Use release tarballs from Github tags, because mirror sites are still
on 9.0.
Add help messages for packages.

Refresh patch:
- 010-no-msgfmt.patch
- 002-remove_helptags_generation.patch

Signed-off-by: Ryan Keane <[email protected]>
@Ra2-IFV Ra2-IFV force-pushed the feat_vim_update-9.1 branch from 36918f7 to e6ff9c1 Compare November 28, 2024 12:03
Copy link
Member

@BKPepe BKPepe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Improving help/description should be in different commit.

PKG_SOURCE:=$(PKG_NAME)-$(PKG_VERSION).tar.bz2
PKG_SOURCE_URL:=http://ftp.vim.org/pub/vim/unix
PKG_HASH:=a6456bc154999d83d0c20d968ac7ba6e7df0d02f3cb6427fb248660bacfb336e
PKG_SOURCE:=v$(PKG_VERSION).tar.gz
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please dont do this. We can not download tarball named like this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did noticed this.. it will create a tarball named like v9.1.0888.tar.gz

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/openwrt/openwrt/blob/main/scripts/download.pl
No, I cant deal with it, why PKG_SOURCE:=foobar PKG_SOURCE_URL:=https://foobar will download tarball from https://foobar/foobar, whyyyyy...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants