-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can't change an open zvol's volsize after a rename #16127
Labels
Type: Defect
Incorrect behavior (e.g. crash, hang)
Comments
asomers
added a commit
to asomers/zfs
that referenced
this issue
Apr 24, 2024
When renaming a zvol, insert it into zvol_htable using the new name, not the old name. Otherwise some operations won't work. For example, "zfs set volsize" while the zvol is open. Sponsored by: Axcient Signed-off-by: Alan Somers <[email protected]> Closes openzfs#16127
13 tasks
behlendorf
pushed a commit
that referenced
this issue
Apr 25, 2024
When renaming a zvol, insert it into zvol_htable using the new name, not the old name. Otherwise some operations won't work. For example, "zfs set volsize" while the zvol is open. Sponsored by: Axcient Reviewed-by: Brian Behlendorf <[email protected]> Reviewed-by: Alek Pinchuk <[email protected]> Signed-off-by: Alan Somers <[email protected]> Closes #16127 Closes #16128
tonyhutter
pushed a commit
that referenced
this issue
May 2, 2024
When renaming a zvol, insert it into zvol_htable using the new name, not the old name. Otherwise some operations won't work. For example, "zfs set volsize" while the zvol is open. Sponsored by: Axcient Reviewed-by: Brian Behlendorf <[email protected]> Reviewed-by: Alek Pinchuk <[email protected]> Signed-off-by: Alan Somers <[email protected]> Closes #16127 Closes #16128
lundman
pushed a commit
to openzfsonwindows/openzfs
that referenced
this issue
Sep 4, 2024
When renaming a zvol, insert it into zvol_htable using the new name, not the old name. Otherwise some operations won't work. For example, "zfs set volsize" while the zvol is open. Sponsored by: Axcient Reviewed-by: Brian Behlendorf <[email protected]> Reviewed-by: Alek Pinchuk <[email protected]> Signed-off-by: Alan Somers <[email protected]> Closes openzfs#16127 Closes openzfs#16128
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
System information
Describe the problem you're observing
It should be possible to successfully do
zfs set volsize
on a zvol even if that zvol is currently open. Indeed it works. However, if the zvol was renamed prior to being opened, then this command will fail with EBUSY.Describe how to reproduce the problem
Include any warning/errors/backtraces from the system logs
None
Investigation so far
Using dtrace, I've determined that
zvol_find_by_name_hash
, as called byzvol_set_volsize
, works when the zvol has not been renamed. But if the zvol has been renamed, then this function fails. Therefore, I suspect a bug inzvol_os_rename_minor
. I intend to keep working on the problem.The text was updated successfully, but these errors were encountered: