Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable block_cloning tests on FreeBSD. #15686

Closed
wants to merge 1 commit into from

Conversation

pjd
Copy link
Contributor

@pjd pjd commented Dec 19, 2023

Motivation and Context

We want as many tests as possible to run on as many platforms as possible.
The following changes allow most of the block_cloning tests to be exercised also on FreeBSD.

Description

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)
  • Tests

Checklist:

@pjd
Copy link
Contributor Author

pjd commented Dec 19, 2023

This PR requires changes to the clonefile tool that are part of the #15631 PR.

@behlendorf behlendorf added Component: Test Suite Indicates an issue with the test framework or a test case Status: Code Review Needed Ready for review and testing labels Dec 19, 2023
@pjd pjd force-pushed the block_cloning-tests-freebsd branch from 1a7e2f8 to f89503a Compare December 20, 2023 05:27
Signed-off-by: Pawel Jakub Dawidek <[email protected]>
@pjd pjd force-pushed the block_cloning-tests-freebsd branch from f89503a to 51fba98 Compare December 27, 2023 07:17
@behlendorf
Copy link
Contributor

@pjd it looks like this just needs a rebase.

@behlendorf
Copy link
Contributor

@pjd I went ahead and opened #15749 with a clean rebase of this for the CI.

@pjd
Copy link
Contributor Author

pjd commented Jan 9, 2024

@pjd I went ahead and opened #15749 with a clean rebase of this for the CI.

I'm sorry, Brian, I missed your previous comment about rebase!

@pjd pjd closed this Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Test Suite Indicates an issue with the test framework or a test case Status: Code Review Needed Ready for review and testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants