Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make spl_kmem_cache size check consistent #15757

Merged
merged 2 commits into from
Jan 16, 2024
Merged

Make spl_kmem_cache size check consistent #15757

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
46d4ddc
Make spl_kmem_cache size check consistent
Jan 11, 2024
13ab5f4
Line length limit
Jan 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions module/os/linux/spl/spl-kmem-cache.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ MODULE_PARM_DESC(spl_kmem_cache_max_size, "Maximum size of slab in MB");
* of 16K was determined to be optimal for architectures using 4K pages and
* to also work well on architecutres using larger 64K page sizes.
*/
static unsigned int spl_kmem_cache_slab_limit = 16384;
static unsigned int spl_kmem_cache_slab_limit = SPL_MAX_KMEM_ORDER_NR_PAGES * PAGE_SIZE;
behlendorf marked this conversation as resolved.
Show resolved Hide resolved
module_param(spl_kmem_cache_slab_limit, uint, 0644);
MODULE_PARM_DESC(spl_kmem_cache_slab_limit,
"Objects less than N bytes use the Linux slab");
Expand Down Expand Up @@ -783,7 +783,7 @@ spl_kmem_cache_create(const char *name, size_t size, size_t align,
} else {
unsigned long slabflags = 0;

if (size > (SPL_MAX_KMEM_ORDER_NR_PAGES * PAGE_SIZE))
if (size > spl_kmem_cache_slab_limit)
goto out;

#if defined(SLAB_USERCOPY)
Expand Down
Loading