Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zdb: Fix false leak report for BRT objects #15882

Merged
merged 1 commit into from
Feb 13, 2024
Merged

zdb: Fix false leak report for BRT objects #15882

merged 1 commit into from
Feb 13, 2024

Conversation

Bi11
Copy link
Contributor

@Bi11 Bi11 commented Feb 11, 2024

Fix a misreport in 'zdb -d' where it falsely marked BRT objects as leaked.

Motivation and Context

zdb -d incorrectly reported BRT objects as leaked.

Description

Add references to BRT objects as with DDT objects.

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

@Bi11
zdb: Fix false leak report for BRT objects
a0add59 
Fix a misreport in 'zdb -d' where it falsely marked
BRT objects as leaked.

Signed-off-by: Yuxin Wang <[email protected]>
amotin
amotin approved these changes Feb 12, 2024
View reviewed changes
Copy link
Member

@amotin amotin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems to have sense.

@behlendorf behlendorf merged commit a0635ae into openzfs:master Feb 13, 2024
24 of 25 checks passed
tonyhutter pushed a commit that referenced this pull request Feb 22, 2024
@Bi11 @tonyhutter
zdb: Fix false leak report for BRT objects
a4978d2 
Fix a misreport in 'zdb -d' where it falsely marked
BRT objects as leaked.

Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by: Alexander Motin <[email protected]>
Signed-off-by: Yuxin Wang <[email protected]>
Closes #15882
lundman pushed a commit to openzfsonwindows/openzfs that referenced this pull request Mar 13, 2024
@Bi11 @lundman
zdb: Fix false leak report for BRT objects
b52eaf9 
Fix a misreport in 'zdb -d' where it falsely marked
BRT objects as leaked.

Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by: Alexander Motin <[email protected]>
Signed-off-by: Yuxin Wang <[email protected]>
Closes openzfs#15882
lundman pushed a commit to openzfsonwindows/openzfs that referenced this pull request Mar 13, 2024
@Bi11 @lundman
zdb: Fix false leak report for BRT objects
d12068d 
Fix a misreport in 'zdb -d' where it falsely marked
BRT objects as leaked.

Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by: Alexander Motin <[email protected]>
Signed-off-by: Yuxin Wang <[email protected]>
Closes openzfs#15882
lundman pushed a commit to openzfsonwindows/openzfs that referenced this pull request Mar 13, 2024
@Bi11 @lundman
zdb: Fix false leak report for BRT objects
6d37de2 
Fix a misreport in 'zdb -d' where it falsely marked
BRT objects as leaked.

Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by: Alexander Motin <[email protected]>
Signed-off-by: Yuxin Wang <[email protected]>
Closes openzfs#15882
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amotin amotin amotin approved these changes

@behlendorf behlendorf behlendorf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Bi11 @behlendorf @amotin