Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ZTS: CI Documentation Updates #16561

Merged
merged 1 commit into from
Sep 24, 2024
Merged

ZTS: CI Documentation Updates #16561

merged 1 commit into from
Sep 24, 2024

Conversation

behlendorf
Copy link
Contributor

Motivation and Context

Update the relevant docs to reflect switch to GitHub Actions workflows for the CI.

Description

Update the CONTRIBUTING.md documention to refer to the GitHub Actions
workflows which have replaced the buildbot infrastructure.

How Has This Been Tested?

Proofread.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

@behlendorf
ZTS: CI Documentation Updates
0f524f2 
Update the CONTRIBUTING.md documention to refer to the GitHub Actions
workflows which have replaced the buildbot infrastructure.

Signed-off-by: Brian Behlendorf <[email protected]>
@behlendorf behlendorf added Component: Test Suite Indicates an issue with the test framework or a test case Type: Documentation Indicates a requested change to the documentation Status: Code Review Needed Ready for review and testing labels Sep 23, 2024
@behlendorf
Copy link
Contributor Author

I've manually cancelled the long running zfs-qemu run for this documentation only PR.

@mcmilk not to get greedy, but it sure would be nice if there was a way to get a shorter CI run for obviously trivial changes like this. Maybe use the sanity.run file if there aren't any code/makefile/test changes in the PR commits? Or check for a label on the PR? Anyway, something to consider.

@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Sep 24, 2024
@behlendorf behlendorf merged commit 9c03b22 into openzfs:master Sep 24, 2024
5 of 20 checks passed
Harry-Chen added a commit to Harry-Chen/zfs that referenced this pull request Sep 24, 2024
@Harry-Chen
CI: run only sanity check on limited OSes when changes are trivial
e8744fb 
The commit uses some heuristics to determine the triviality of a PR.

It runs "quick" CI (i.e., only use sanity.run on fewer OSes)
if (explicity required by user):
- the *last* commit message contains a line 'ZFS-CI-Type: quick',
or if (by heuristics):
- the files changed are not in the list of specified directory, and
- all commit messages does not contain 'ZFS-CI-Type: full'.

It runs "full" CI otherwise.

See: openzfs#16561 (comment)
Signed-off-by: Shengqi Chen <[email protected]>
@Harry-Chen Harry-Chen mentioned this pull request Sep 24, 2024
Merged
13 tasks
Harry-Chen added a commit to Harry-Chen/zfs that referenced this pull request Sep 24, 2024
@Harry-Chen
CI: run only sanity check on limited OSes when changes are trivial
538841b 
The commit uses some heuristics to determine the triviality of a PR.

It runs "quick" CI (i.e., only use sanity.run on fewer OSes)
if (explicity required by user):
- the *last* commit message contains a line 'ZFS-CI-Type: quick',
or if (by heuristics):
- the files changed are not in the list of specified directory, and
- all commit messages does not contain 'ZFS-CI-Type: full'.

It runs "full" CI otherwise.

See: openzfs#16561 (comment)
Signed-off-by: Shengqi Chen <[email protected]>
@Harry-Chen Harry-Chen mentioned this pull request Sep 24, 2024
Closed
13 tasks
Harry-Chen added a commit to Harry-Chen/zfs that referenced this pull request Sep 24, 2024
@Harry-Chen
CI: run only sanity check on limited OSes when changes are trivial
cae6107 
The commit uses some heuristics to determine the triviality of a PR.

It runs "quick" CI (i.e., only use sanity.run on fewer OSes)
if (explicity required by user):
- the *last* commit message contains a line 'ZFS-CI-Type: quick',
or if (by heuristics):
- the files changed are not in the list of specified directory, and
- all commit messages does not contain 'ZFS-CI-Type: full'.

It runs "full" CI otherwise.

See: openzfs#16561 (comment)
Signed-off-by: Shengqi Chen <[email protected]>
Harry-Chen added a commit to Harry-Chen/zfs that referenced this pull request Sep 24, 2024
@Harry-Chen
CI: run only sanity check on limited OSes when changes are trivial
47e9139 
The commit uses some heuristics to determine the triviality of a PR.

It runs "quick" CI (i.e., only use sanity.run on fewer OSes)
if (explicity required by user):
- the *last* commit message contains a line 'ZFS-CI-Type: quick',
or if (by heuristics):
- the files changed are not in the list of specified directory, and
- all commit messages does not contain 'ZFS-CI-Type: full'.

It runs "full" CI otherwise.

See: openzfs#16561 (comment)
Signed-off-by: Shengqi Chen <[email protected]>
Harry-Chen added a commit to Harry-Chen/zfs that referenced this pull request Sep 25, 2024
@Harry-Chen
CI: run only sanity check on limited OSes for nonbehavioral changes
ae04fc6 
The commit uses heuristics to determine whether a PR is behavioral:

It runs "quick" CI (i.e., only use sanity.run on fewer OSes)
if (explicity required by user):
- the *last* commit message contains a line 'ZFS-CI-Type: quick',
or if (by heuristics):
- the files changed are not in the list of specified directory, and
- all commit messages does not contain 'ZFS-CI-Type: full'.

It runs "full" CI otherwise.

See: openzfs#16561 (comment)
Signed-off-by: Shengqi Chen <[email protected]>
robn pushed a commit to robn/zfs that referenced this pull request Nov 5, 2024
@behlendorf @tonyhutter
ZTS: CI Documentation Updates
1b27b76 
Update the CONTRIBUTING.md documentation to refer to the GitHub Actions
workflows which have replaced the buildbot infrastructure.

Signed-off-by: Brian Behlendorf <[email protected]>
Closes openzfs#16561
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Component: Test Suite Indicates an issue with the test framework or a test case Status: Accepted Ready to integrate (reviewed, tested) Type: Documentation Indicates a requested change to the documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@behlendorf