-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ZTS: Fix summary page creation #16599
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are cases, where some needed files for the summary page aren't created. Currently the whole Summary Page creation will fail then. Sample run: https://github.com/openzfs/zfs/actions/runs/11148248072/job/30999748588 Fix this, by properly checking for existence of the needed files. Signed-off-by: Tino Reichardt <[email protected]>
robn
approved these changes
Oct 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two earnest and dumb questions:
- is a missing file interesting? Would it be better to put
[uname.txt not found]
in the report instead? -s
will skip zero-byte files too. Should it be-e
? and/or, put[uname.txt empty]
in the report?
No, we have the red light that indicates that e.g. the module build has failed.
When uname.txt exists, then there should be some content in it, thats why I used |
tonyhutter
approved these changes
Oct 3, 2024
behlendorf
approved these changes
Oct 3, 2024
Told you they were dumb 😊 |
tonyhutter
pushed a commit
to tonyhutter/zfs
that referenced
this pull request
Oct 3, 2024
There are cases, where some needed files for the summary page aren't created. Currently the whole Summary Page creation will fail then. Sample run: https://github.com/openzfs/zfs/actions/runs/11148248072/job/30999748588 Fix this, by properly checking for existence of the needed files. Reviewed-by: Tony Hutter <[email protected]> Reviewed-by: Brian Behlendorf <[email protected]> Reviewed-by: Rob Norris <[email protected]> Signed-off-by: Tino Reichardt <[email protected]> Closes openzfs#16599
tonyhutter
pushed a commit
to tonyhutter/zfs
that referenced
this pull request
Oct 3, 2024
There are cases, where some needed files for the summary page aren't created. Currently the whole Summary Page creation will fail then. Sample run: https://github.com/openzfs/zfs/actions/runs/11148248072/job/30999748588 Fix this, by properly checking for existence of the needed files. Reviewed-by: Tony Hutter <[email protected]> Reviewed-by: Brian Behlendorf <[email protected]> Reviewed-by: Rob Norris <[email protected]> Signed-off-by: Tino Reichardt <[email protected]> Closes openzfs#16599
tonyhutter
pushed a commit
to tonyhutter/zfs
that referenced
this pull request
Oct 3, 2024
There are cases, where some needed files for the summary page aren't created. Currently the whole Summary Page creation will fail then. Sample run: https://github.com/openzfs/zfs/actions/runs/11148248072/job/30999748588 Fix this, by properly checking for existence of the needed files. Reviewed-by: Tony Hutter <[email protected]> Reviewed-by: Brian Behlendorf <[email protected]> Reviewed-by: Rob Norris <[email protected]> Signed-off-by: Tino Reichardt <[email protected]> Closes openzfs#16599
mcmilk
added a commit
to mcmilk/zfs
that referenced
this pull request
Oct 6, 2024
In PR openzfs#16599 I used 'return' like in C - which is wrong :/ This fix generates the summary as needed. Signed-off-by: Tino Reichardt <[email protected]>
13 tasks
behlendorf
pushed a commit
that referenced
this pull request
Oct 6, 2024
In PR #16599 I used 'return' like in C - which is wrong :/ This fix generates the summary as needed. Reviewed-by: Brian Behlendorf <[email protected]> Signed-off-by: Tino Reichardt <[email protected]> Closes #16611
ixhamza
pushed a commit
to truenas/zfs
that referenced
this pull request
Oct 8, 2024
In PR openzfs#16599 I used 'return' like in C - which is wrong :/ This fix generates the summary as needed. Reviewed-by: Brian Behlendorf <[email protected]> Signed-off-by: Tino Reichardt <[email protected]> Closes openzfs#16611
ixhamza
pushed a commit
to truenas/zfs
that referenced
this pull request
Oct 9, 2024
In PR openzfs#16599 I used 'return' like in C - which is wrong :/ This fix generates the summary as needed. Reviewed-by: Brian Behlendorf <[email protected]> Signed-off-by: Tino Reichardt <[email protected]> Closes openzfs#16611
behlendorf
pushed a commit
to behlendorf/zfs
that referenced
this pull request
Oct 9, 2024
In PR openzfs#16599 I used 'return' like in C - which is wrong :/ This fix generates the summary as needed. Reviewed-by: Brian Behlendorf <[email protected]> Signed-off-by: Tino Reichardt <[email protected]> Closes openzfs#16611
ixhamza
pushed a commit
to truenas/zfs
that referenced
this pull request
Oct 9, 2024
In PR openzfs#16599 I used 'return' like in C - which is wrong :/ This fix generates the summary as needed. Reviewed-by: Brian Behlendorf <[email protected]> Signed-off-by: Tino Reichardt <[email protected]> Closes openzfs#16611
robn
pushed a commit
to robn/zfs
that referenced
this pull request
Nov 5, 2024
There are cases, where some needed files for the summary page aren't created. Currently the whole Summary Page creation will fail then. Sample run: https://github.com/openzfs/zfs/actions/runs/11148248072/job/30999748588 Fix this, by properly checking for existence of the needed files. Reviewed-by: Tony Hutter <[email protected]> Reviewed-by: Brian Behlendorf <[email protected]> Reviewed-by: Rob Norris <[email protected]> Signed-off-by: Tino Reichardt <[email protected]> Closes openzfs#16599
robn
pushed a commit
to robn/zfs
that referenced
this pull request
Nov 5, 2024
In PR openzfs#16599 I used 'return' like in C - which is wrong :/ This fix generates the summary as needed. Reviewed-by: Brian Behlendorf <[email protected]> Signed-off-by: Tino Reichardt <[email protected]> Closes openzfs#16611
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
There are cases, where some needed files for the summary page aren't created. Currently the whole Summary Page creation will fail then. Sample run: https://github.com/openzfs/zfs/actions/runs/11148248072/job/30999748588
Fix this, by properly checking for existence of the needed files.
How Has This Been Tested?
The ZTS will do.
Types of changes
Checklist:
Signed-off-by
.