Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FreeBSD: Lock vnode in zfs_ioctl() #16796

Merged
merged 1 commit into from
Nov 23, 2024
Merged

FreeBSD: Lock vnode in zfs_ioctl() #16796

merged 1 commit into from
Nov 23, 2024

Conversation

amotin
Copy link
Member

@amotin amotin commented Nov 21, 2024

Previously vnode was not locked there, unlike Linux. It required locking it in vn_flush_cached_data(), which recursed on the lock if called from zfs_clone_range(), having the vnode locked.

Closes #16789

How Has This Been Tested?

Minimally. Run cp without block cloning and fsx from #16789.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

@amotin
FreeBSD: Lock vnode in zfs_ioctl()
fd602d3 
Previously vnode was not locked there, unlike Linux.  It required
locking it in vn_flush_cached_data(), which recursed on the lock
if called from zfs_clone_range(), having the vnode locked.

Signed-off-by:	Alexander Motin <[email protected]>
Sponsored by:	iXsystems, Inc.
Closes	openzfs#16789
This was referenced Nov 22, 2024
Merged
Closed
@amotin amotin added the Status: Code Review Needed Ready for review and testing label Nov 22, 2024
asomers
asomers approved these changes Nov 22, 2024
View reviewed changes
Copy link
Contributor

@asomers asomers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, and works too.

@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Nov 23, 2024
@behlendorf behlendorf merged commit b3b0ce6 into openzfs:master Nov 23, 2024
24 checks passed
behlendorf pushed a commit to behlendorf/zfs that referenced this pull request Nov 23, 2024
@amotin @behlendorf
FreeBSD: Lock vnode in zfs_ioctl()
eda3968 
Previously vnode was not locked there, unlike Linux.  It required
locking it in vn_flush_cached_data(), which recursed on the lock
if called from zfs_clone_range(), having the vnode locked.

Reviewed-by: Alan Somers <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Alexander Motin <[email protected]>
Sponsored by: iXsystems, Inc.
Closes openzfs#16789
Closes openzfs#16796
@amotin amotin deleted the lk_shared_holey branch November 24, 2024 00:08
ixhamza pushed a commit to truenas/zfs that referenced this pull request Dec 2, 2024
@amotin @ixhamza
FreeBSD: Lock vnode in zfs_ioctl()
a3a4547 
Previously vnode was not locked there, unlike Linux.  It required
locking it in vn_flush_cached_data(), which recursed on the lock
if called from zfs_clone_range(), having the vnode locked.

Reviewed-by: Alan Somers <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Alexander Motin <[email protected]>
Sponsored by: iXsystems, Inc.
Closes openzfs#16789
Closes openzfs#16796
behlendorf pushed a commit to behlendorf/zfs that referenced this pull request Dec 3, 2024
@amotin @behlendorf
FreeBSD: Lock vnode in zfs_ioctl()
9060360 
Previously vnode was not locked there, unlike Linux.  It required
locking it in vn_flush_cached_data(), which recursed on the lock
if called from zfs_clone_range(), having the vnode locked.

Reviewed-by: Alan Somers <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Alexander Motin <[email protected]>
Sponsored by: iXsystems, Inc.
Closes openzfs#16789
Closes openzfs#16796
rkojedzinszky pushed a commit to dravanet/openzfs-zfs that referenced this pull request Dec 16, 2024
@amotin @rkojedzinszky
FreeBSD: Lock vnode in zfs_ioctl()
3a98223 
Previously vnode was not locked there, unlike Linux.  It required
locking it in vn_flush_cached_data(), which recursed on the lock
if called from zfs_clone_range(), having the vnode locked.

Reviewed-by: Alan Somers <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Alexander Motin <[email protected]>
Sponsored by: iXsystems, Inc.
Closes openzfs#16789
Closes openzfs#16796
rkojedzinszky pushed a commit to dravanet/openzfs-zfs that referenced this pull request Dec 16, 2024
@amotin @rkojedzinszky
FreeBSD: Lock vnode in zfs_ioctl()
8544d9b 
Previously vnode was not locked there, unlike Linux.  It required
locking it in vn_flush_cached_data(), which recursed on the lock
if called from zfs_clone_range(), having the vnode locked.

Reviewed-by: Alan Somers <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Alexander Motin <[email protected]>
Sponsored by: iXsystems, Inc.
Closes openzfs#16789
Closes openzfs#16796
rkojedzinszky pushed a commit to dravanet/openzfs-zfs that referenced this pull request Dec 16, 2024
@amotin @rkojedzinszky
FreeBSD: Lock vnode in zfs_ioctl()
7d41b36 
Previously vnode was not locked there, unlike Linux.  It required
locking it in vn_flush_cached_data(), which recursed on the lock
if called from zfs_clone_range(), having the vnode locked.

Reviewed-by: Alan Somers <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Alexander Motin <[email protected]>
Sponsored by: iXsystems, Inc.
Closes openzfs#16789
Closes openzfs#16796
rkojedzinszky pushed a commit to dravanet/openzfs-zfs that referenced this pull request Dec 30, 2024
@amotin @rkojedzinszky
FreeBSD: Lock vnode in zfs_ioctl()
a9fc327 
Previously vnode was not locked there, unlike Linux.  It required
locking it in vn_flush_cached_data(), which recursed on the lock
if called from zfs_clone_range(), having the vnode locked.

Reviewed-by: Alan Somers <[email protected]>
Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Alexander Motin <[email protected]>
Sponsored by: iXsystems, Inc.
Closes openzfs#16789
Closes openzfs#16796
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@behlendorf behlendorf behlendorf approved these changes

@asomers asomers asomers approved these changes

Assignees
No one assigned
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

panic: excl->share in zfs_clone_range when block_cloning is enabled
3 participants
@amotin @asomers @behlendorf