Destroy ARC buffer in case of fill error

In case of error dmu_buf_fill_done() returns the buffer back into DB_UNCACHED state. Since during transition from DB_UNCACHED into DB_FILL state dbuf_noread() allocates an ARC buffer, we must free it here, otherwise it will be leaked. Fixes: openzfs#15665 Closes: openzfs#15802 Signed-off-by: Alexander Motin <[email protected]> Sponsored by: iXsystems, Inc.
openzfsonwindows · May 23, 2024 · f537d5e · f537d5e
1 parent 3fe6bd2
commit f537d5e
Showing 1 changed file with 1 addition and 0 deletions.
diff --git a/module/zfs/dbuf.c b/module/zfs/dbuf.c
@@ -2856,6 +2856,7 @@ dmu_buf_fill_done(dmu_buf_t *dbuf, dmu_tx_t *tx, boolean_t failed)
 			failed = B_FALSE;
 		} else if (failed) {
 			VERIFY(!dbuf_undirty(db, tx));
+			arc_buf_destroy(db->db_buf, db);
 			db->db_buf = NULL;
 			dbuf_clear_data(db);
 			DTRACE_SET_STATE(db, "fill failed");