Check SPL free thread is running before trying to set memory pressure. #338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lundman
approved these changes
Dec 5, 2023
|
Thanks for doing this, LGTM. |
lundman
merged commit c36e951
into
openzfsonwindows:zfs-Windows-2.2.0-release
25 of 30 checks passed
datacore-rm
added a commit
to DataCoreSoftware/openzfs
that referenced
this pull request
Dec 5, 2023
datacore-rm
added a commit
to DataCoreSoftware/openzfs
that referenced
this pull request
Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #336, the memory allocation failed during init. The free thread was not running and its cond var/mutex was not initialized. So checking free thread is running before trying to set the memory pressure.