-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Any plan for supporting async/await? #175
Comments
+1 |
some of the related issues are stuck on feedback. anyone want to comment on #135 (comment) ? |
PR #201 adds this functionality |
So you can solve async await issues by feeding your own CLSContext implementation to a tracer. Just use |
@joepuzzo would you be up for a PR fixing this (of course count us in for
reviews)
Den fre. 14. des. 2018, 16:24 skrev Joe Puzzo <[email protected]:
… So you can solve async await issues by feeding your own CLSContext
implementation to a tracer. Just use cls-hooked instead of
continuation-local-storage
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#175 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AC7sAl3DgJe4FYKs6Plg-qOAAas324iGks5u48KXgaJpZM4RJTLN>
.
|
So i dont think you want me doing that tbh.. currently the lib uses continuation-local-storage which is the main supported lib.. the cls-hooks version is a fork that sounds like will eventually be merged into the main lib |
The workaround is simple enough for now.. however one thing i could simply do is provide a second class AsyncCLSContext that was included with lib |
Addressed by #476 |
As mentioned in #124 and #135, this package does not work very well in node 8. Is there any schedule for something like zipkin-js@next or zipkin-js 2.x?
The text was updated successfully, but these errors were encountered: