Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Any plan for supporting async/await? #175

Closed
sleagon opened this issue Dec 21, 2017 · 8 comments
Closed

Any plan for supporting async/await? #175

sleagon opened this issue Dec 21, 2017 · 8 comments

Comments

@sleagon
Copy link

sleagon commented Dec 21, 2017

As mentioned in #124 and #135, this package does not work very well in node 8. Is there any schedule for something like zipkin-js@next or zipkin-js 2.x?

@Fannon
Copy link

Fannon commented Feb 27, 2018

+1

@codefromthecrypt
Copy link
Member

some of the related issues are stuck on feedback. anyone want to comment on #135 (comment) ?

@Ghost---Shadow
Copy link

PR #201 adds this functionality

@joepuzzo
Copy link

So you can solve async await issues by feeding your own CLSContext implementation to a tracer. Just use cls-hooked instead of continuation-local-storage

@jcchavezs
Copy link
Contributor

jcchavezs commented Dec 14, 2018 via email

@joepuzzo
Copy link

So i dont think you want me doing that tbh.. currently the lib uses continuation-local-storage which is the main supported lib.. the cls-hooks version is a fork that sounds like will eventually be merged into the main lib

@joepuzzo
Copy link

The workaround is simple enough for now.. however one thing i could simply do is provide a second class AsyncCLSContext that was included with lib

@jcchavezs
Copy link
Contributor

Addressed by #476

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants