Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Guard Against Multiple 'zrok enable' #190

Closed
dovholuknf opened this issue Jan 30, 2023 · 2 comments
Closed

Guard Against Multiple 'zrok enable' #190

dovholuknf opened this issue Jan 30, 2023 · 2 comments
Assignees
@michaelquigley
Labels
enhancement Enhancement of an existing feature
Milestone
v0.3

Comments

@dovholuknf
Copy link
Member

It's not clear why zrok fails when running zrok enable ${token} on the same machine more than once.

Expected Behavior:
zrok should inform me I'm already enabled, or just tell me that the machine is enabled

Actual Behavior:
zrok indicates an error enabling my environment
@michaelquigley michaelquigley changed the title zrok enable fails when run a second time on the same machine Guard Against Multiple 'zrok enable' Jan 30, 2023
@michaelquigley michaelquigley added the enhancement Enhancement of an existing feature label Jan 30, 2023
@michaelquigley michaelquigley modified the milestones: v0.4, v0.3 Jan 30, 2023
michaelquigley added a commit that referenced this issue Jan 30, 2023
@michaelquigley
guard against multiple 'zrok enable' (#190)
c633b13
@michaelquigley michaelquigley moved this from Backlog to Development in zrok Development Roadmap Jan 30, 2023
@michaelquigley michaelquigley self-assigned this Jan 30, 2023
@michaelquigley michaelquigley moved this from Development to Evaluating in zrok Development Roadmap Jan 30, 2023
@michaelquigley
Copy link
Collaborator

This is a regression. Corrected in v0.3.0-rc6:

[ERROR] you already have an enabled environment, zrok disable first before you zrok enable

@dovholuknf
Copy link
Member Author

It'd be nice if it didn't error if i used the same token as already configured

@github-project-automation github-project-automation bot moved this from Evaluating to Done in zrok Development Roadmap Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@michaelquigley michaelquigley

Labels
enhancement Enhancement of an existing feature
Projects
zrok Development Roadmap
Status: Done
Milestone
v0.3
Development

No branches or pull requests
2 participants
@michaelquigley @dovholuknf