Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Resource Cleanup Resilience #533

Closed
michaelquigley opened this issue Jan 17, 2024 · 0 comments
Closed

Improve Resource Cleanup Resilience #533

michaelquigley opened this issue Jan 17, 2024 · 0 comments
Assignees
Labels
enhancement Enhancement of an existing feature
Milestone

Comments

@michaelquigley
Copy link
Collaborator

Improve the resilience of the deallocateResources function such that it logs errors for each step, and continues proceeding through the cleanup process.

func (h *unshareHandler) deallocateResources(senv *store.Environment, shrToken, shrZId string, edge *rest_management_api_client.ZitiEdgeManagement) error {
    if err := zrokEdgeSdk.DeleteServiceEdgeRouterPolicy(senv.ZId, shrToken, edge); err != nil {
        return err
    }
    if err := zrokEdgeSdk.DeleteServicePoliciesDial(senv.ZId, shrToken, edge); err != nil {
        return err
    }
    if err := zrokEdgeSdk.DeleteServicePoliciesBind(senv.ZId, shrToken, edge); err != nil {
        return err
    }
    if err := zrokEdgeSdk.DeleteConfig(senv.ZId, shrToken, edge); err != nil {
        return err
    }
    if err := zrokEdgeSdk.DeleteService(senv.ZId, shrZId, edge); err != nil {
        return err
    }
    return nil
}
@michaelquigley michaelquigley self-assigned this Jan 17, 2024
@michaelquigley michaelquigley added the enhancement Enhancement of an existing feature label Jan 17, 2024
@michaelquigley michaelquigley added this to the v0.4 milestone Jan 17, 2024
@michaelquigley michaelquigley moved this from Backlog to Development in zrok Development Roadmap Jan 17, 2024
michaelquigley added a commit that referenced this issue Jan 17, 2024
Improved Resource Cleanup Resiience (#533)
@michaelquigley michaelquigley moved this from Development to Evaluating in zrok Development Roadmap Jan 17, 2024
@michaelquigley michaelquigley moved this from Evaluating to Done in zrok Development Roadmap Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement of an existing feature
Projects
Development

No branches or pull requests

1 participant