Output name, but dont mark as writable attribute

opf · Mar 22, 2021 · c3edd40 · c3edd40
1 parent b1b9591
commit c3edd40
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 5 deletions.
diff --git a/app/contracts/users/base_contract.rb b/app/contracts/users/base_contract.rb
@@ -36,7 +36,6 @@ class BaseContract < ::ModelContract
               writeable: ->(*) { user.allowed_to_globally?(:manage_user) && model.id != user.id }
     attribute :firstname
     attribute :lastname
-    attribute :name
     attribute :mail
     attribute :admin,
               writeable: ->(*) { user.admin? && model.id != user.id }

diff --git a/lib/api/v3/principals/principal_representer.rb b/lib/api/v3/principals/principal_representer.rb
@@ -62,7 +62,6 @@ class PrincipalRepresenter < ::API::Decorators::Single
                  render_nil: true
 
         property :name,
-                 skip_render: ->(*) { is_a?(User) },
                  render_nil: true
 
         date_time_property :created_at,

diff --git a/lib/api/v3/users/schemas/user_schema_representer.rb b/lib/api/v3/users/schemas/user_schema_representer.rb
@@ -53,6 +53,11 @@ class UserSchemaRepresenter < ::API::Decorators::SchemaRepresenter
                  min_length: 1,
                  max_length: 255
 
+          schema :name,
+                 type: 'String',
+                 required: false,
+                 writable: false
+
           schema :firstname,
                  as: :firstName,
                  type: 'String',

diff --git a/spec/requests/api/v3/user/create_form_resource_spec.rb b/spec/requests/api/v3/user/create_form_resource_spec.rb
@@ -60,9 +60,6 @@
         expect(body)
           .to be_json_eql(''.to_json)
                 .at_path('_embedded/payload/login')
-        expect(body)
-          .to be_json_eql(' '.to_json)
-                .at_path('_embedded/payload/name')
         expect(body)
           .to be_json_eql(''.to_json)
                 .at_path('_embedded/payload/email')