Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce side panel #138

Merged
merged 6 commits into from
Jul 11, 2024
Merged

Introduce side panel #138

merged 6 commits into from
Jul 11, 2024

Conversation

oliverguenther
Copy link
Member

@oliverguenther oliverguenther commented Jul 3, 2024 •
edited
Loading

Authors: Please fill out this form carefully and completely.

Reviewers: By approving this Pull Request you are approving the code change, as well as its deployment and mitigation plans.
Please read this description carefully. If you feel there is anything unclear or missing, please ask for updates.

What are you trying to accomplish?

Add a reusable side panel component

Screenshots

Integration

List the issues that this change affects.

Closes # (type the GitHub issue number after #)

Risk Assessment

  • Low risk the change is small, highly observable, and easily rolled back.
  • Medium risk changes that are isolated, reduced in scope or could impact few users. The change will not impact library availability.
  • High risk changes are those that could impact customers and SLOs, low or no test coverage, low observability, or slow to rollback.

What approach did you choose and why?

Anything you want to highlight for special attention from reviewers?

Accessibility

  • Fixes axe scan violation - This change fixes an existing axe scan violation.
  • No new axe scan violation - This change does not introduce any new axe scan violations.
  • New axe violation - This change introduces a new axe scan violation. Please describe why the violation cannot be resolved below.

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Added/updated previews (Lookbook)
  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jul 3, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 98a0c00

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@openproject/primer-view-components Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@oliverguenther oliverguenther force-pushed the feat/side-panel branch 2 times, most recently from f3d7ea9 to 0d9743b Compare July 5, 2024 06:59
@oliverguenther oliverguenther marked this pull request as ready for review July 10, 2024 08:01
@oliverguenther oliverguenther force-pushed the feat/side-panel branch 2 times, most recently from cfe2437 to 7d69375 Compare July 10, 2024 08:27
@oliverguenther oliverguenther force-pushed the feat/side-panel branch 3 times, most recently from d49a6f0 to 4215f7c Compare July 10, 2024 11:12
HDinger
HDinger requested changes Jul 10, 2024
View reviewed changes
Copy link
Collaborator

@HDinger HDinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall 👍 I have some minor remarks, nothing too critical.
I am wondering whether we want to hide the BorderGrid from the list of previews, now that it is more an internal component than meant to be used standalone. At least, I'd leave a comment somewhere mentioning that. What do you think?

.changeset/brave-impalas-grab.md Outdated Show resolved Hide resolved
app/components/primer/open_project/side_panel.pcss Outdated

.SidePanel-sectionContent,
.SidePanel-sectionDescription {
margin-top: 4px;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not enough for the Content, if there is a description as well:
Bildschirmfoto 2024-07-10 um 13 17 18

The spacings are a bit tricky due to the elements having differentl line hights. Thus the spacing looks sometimes larger that it actually is. If you want, I can help you with that.

app/components/primer/open_project/side_panel/section.rb Show resolved Hide resolved
previews/primer/open_project/side_panel_preview/with_component.html.erb Show resolved Hide resolved
test/components/component_test.rb Outdated Show resolved Hide resolved
@oliverguenther oliverguenther force-pushed the feat/side-panel branch 2 times, most recently from 67bcf94 to a6931e5 Compare July 10, 2024 12:10
HDinger
HDinger approved these changes Jul 11, 2024
View reviewed changes
Copy link
Collaborator

@HDinger HDinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to merge once the tests are green 👍

@github-actions GitHub Actions
Copy link

⚠️ Visual differences found

Our visual comparison tests found UI differences. Please review the differences by viewing the files changed tab to ensure that the changes were intentional.

Review visual differences

@HDinger HDinger merged commit e8a8446 into main Jul 11, 2024
@HDinger HDinger deleted the feat/side-panel branch July 11, 2024 08:38
@openprojectci openprojectci mentioned this pull request Jul 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HDinger HDinger HDinger approved these changes

Assignees
No one assigned
Labels
minor release
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oliverguenther @HDinger