Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[52582] Update the PageHeader component to do all required actions #81

Conversation

HDinger
Copy link
Collaborator

@HDinger HDinger commented Feb 16, 2024

Goal

The goal of this PR is to change the Primer::OpenProject::PageHeader component to fullfill all new requirements. This is a preparational step to harmoinze all headers within OpenProject.

To Do

  • h1 should be the default tag
  • Add spacing between titleBar and description (especially needed for medium variant)
  • Replace the backButton slot with a generic leadingAction like it is defined here
  • On mobile the divider will not disappear
  • Turn singular actions slot into collection of action slots where each already has a margin so that buttons inside the actions don't need to all add a margin themselves

Out of scope

  • On mobile, the PageHeader will contain a maximum of 1 action. If there is multiple actions this action will be a three dots vertical more menu.
  • Have a variant/state of the page component that is rendered when editing. In that variant/state, a form will replace the title area and there will be different actions than when in show mode

https://community.openproject.org/projects/openproject/work_packages/52582/activity
https://community.openproject.org/projects/openproject/work_packages/52399/activity

Copy link

changeset-bot bot commented Feb 16, 2024

🦋 Changeset detected

Latest commit: 60b2352

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@openproject/primer-view-components Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@HDinger HDinger marked this pull request as draft February 16, 2024 09:13
@HDinger HDinger force-pushed the feature/52582-update-the-pageheader-component-to-do-all-required-actions branch from 780a4aa to 82b9f75 Compare February 20, 2024 12:58
Copy link

github-actions bot commented Feb 21, 2024

⚠️ Visual differences found

Our visual comparison tests found UI differences. Please review the differences by viewing the files changed tab to ensure that the changes were intentional.

Review visual differences

@HDinger HDinger marked this pull request as ready for review March 5, 2024 07:49
@HDinger HDinger force-pushed the feature/52582-update-the-pageheader-component-to-do-all-required-actions branch from 4c28057 to b2011f7 Compare March 5, 2024 07:52
@HDinger HDinger force-pushed the feature/52582-update-the-pageheader-component-to-do-all-required-actions branch from e694b6a to 60b2352 Compare March 5, 2024 08:19
@HDinger HDinger merged commit 9ebb99b into main Mar 5, 2024
29 checks passed
@HDinger HDinger deleted the feature/52582-update-the-pageheader-component-to-do-all-required-actions branch March 5, 2024 08:26
@openprojectci openprojectci mentioned this pull request Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

1 participant