forked from primer/view_components
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[52582] Update the PageHeader component to do all required actions #81
Merged
HDinger
merged 12 commits into
main
from
feature/52582-update-the-pageheader-component-to-do-all-required-actions
Mar 5, 2024
Merged
[52582] Update the PageHeader component to do all required actions #81
HDinger
merged 12 commits into
main
from
feature/52582-update-the-pageheader-component-to-do-all-required-actions
Mar 5, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 60b2352 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
HDinger
force-pushed
the
feature/52582-update-the-pageheader-component-to-do-all-required-actions
branch
from
February 20, 2024 12:58
780a4aa
to
82b9f75
Compare
|
HDinger
force-pushed
the
feature/52582-update-the-pageheader-component-to-do-all-required-actions
branch
from
March 5, 2024 07:52
4c28057
to
b2011f7
Compare
… margin so that buttons inside the actions don't need to all add a margin themselves
HDinger
force-pushed
the
feature/52582-update-the-pageheader-component-to-do-all-required-actions
branch
from
March 5, 2024 08:19
e694b6a
to
60b2352
Compare
HDinger
deleted the
feature/52582-update-the-pageheader-component-to-do-all-required-actions
branch
March 5, 2024 08:26
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
The goal of this PR is to change the
Primer::OpenProject::PageHeader
component to fullfill all new requirements. This is a preparational step to harmoinze all headers within OpenProject.To Do
h1
should be the default tagmedium
variant)backButton
slot with a genericleadingAction
like it is defined hereOut of scope
https://community.openproject.org/projects/openproject/work_packages/52582/activity
https://community.openproject.org/projects/openproject/work_packages/52399/activity