Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Junaed/fssdk 1119 test js to ts #1002

Merged
merged 10 commits into from
Feb 19, 2025

Conversation

junaed-optimizely
Copy link
Contributor

@junaed-optimizely junaed-optimizely commented Feb 12, 2025

Summary

Test conversion from JS (Mocha, Chai, Sinon) to Vitest

  • bucketer
  • custom_attribute_condition_evaluator
  • decision

Test plan

TS tests have been added

Issues

FSSDK-11119

@coveralls
Copy link

coveralls commented Feb 17, 2025

Coverage Status

coverage: 82.069% (+0.007%) from 82.062%
when pulling 45cf209 on junaed/fssdk-1119-test-js-to-ts
into 49c6b8a on master.

@junaed-optimizely junaed-optimizely marked this pull request as ready for review February 17, 2025 17:06
lib/core/bucketer/index.spec.ts Outdated Show resolved Hide resolved
lib/core/bucketer/index.spec.ts Outdated Show resolved Hide resolved
lib/core/bucketer/index.spec.ts Outdated Show resolved Hide resolved
lib/core/bucketer/index.spec.ts Outdated Show resolved Hide resolved
@junaed-optimizely junaed-optimizely merged commit 6114533 into master Feb 19, 2025
15 of 19 checks passed
@junaed-optimizely junaed-optimizely deleted the junaed/fssdk-1119-test-js-to-ts branch February 19, 2025 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants