Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Profile card component #144

Open
wants to merge 18 commits into
base: profile_card_component
Choose a base branch
from
Open

Profile card component #144

wants to merge 18 commits into from

Conversation

ngumokenneth
Copy link

profile_card_component-desktop
profile_card_component-mobile

almirsarajcic
almirsarajcic requested changes Oct 12, 2023
View reviewed changes
Copy link
Member

@almirsarajcic almirsarajcic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Labels font is a little bit different in design and maybe the width of the component.

package.json Outdated Show resolved Hide resolved
challenges/profile_card_component/index.html Outdated Show resolved Hide resolved
almirsarajcic
almirsarajcic requested changes Oct 18, 2023
View reviewed changes
Copy link
Member

@almirsarajcic almirsarajcic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. You need to revert changes to package-lock.json and package.json files, though.

package.json Outdated Show resolved Hide resolved
almirsarajcic
almirsarajcic requested changes Oct 25, 2023
View reviewed changes
Copy link
Member

@almirsarajcic almirsarajcic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still there.

almirsarajcic
almirsarajcic requested changes Oct 26, 2023
View reviewed changes
Copy link
Member

@almirsarajcic almirsarajcic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still not fixed.
Screenshot 2023-10-26 at 11 44 31

@ngumokenneth ngumokenneth force-pushed the profile_card_component branch from cf49a86 to 8b67c48 Compare October 26, 2023 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@almirsarajcic almirsarajcic almirsarajcic approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ngumokenneth @almirsarajcic