Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Qr code component challenge #155

Open
wants to merge 13 commits into
base: qr_code_component
Choose a base branch
from
Open

Qr code component challenge #155

wants to merge 13 commits into from

Conversation

akinyiv
Copy link

@akinyiv akinyiv commented Jan 26, 2024 •
edited
Loading

image

@akinyiv akinyiv changed the base branch from main to qr_code_component January 29, 2024 06:51
almirsarajcic
almirsarajcic requested changes Jan 29, 2024
View reviewed changes
Copy link
Member

@almirsarajcic almirsarajcic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull from upstream. I recommend reading more about git and GitHub.

@akinyiv
Copy link
Author

akinyiv commented Jan 29, 2024 via email

almirsarajcic
almirsarajcic requested changes Jan 30, 2024
View reviewed changes
Copy link
Member

@almirsarajcic almirsarajcic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

npm run format

almirsarajcic
almirsarajcic requested changes Jan 31, 2024
View reviewed changes
Copy link
Member

@almirsarajcic almirsarajcic left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now the tests are failing.

frontend_mentor_challenges/package.json

Lines 19 to 28 in 7282120

"scripts": {
"build": "node scripts/build.js",
"check-formatting": "npx prettier -c .",
"format": "npx prettier -w .",
"serve": "npm-run-all --parallel watch simple-autoreload-server",
"simple-autoreload-server": "npx autoreload-server -d ./public/ -p 3000 -b",
"test": "npm-run-all check-formatting build wdio-test",
"watch": "npm run build -- --watch",
"wdio-test": "npx wdio run wdio.conf.js"
}

Run the npm run test command locally and fix it until everything is passing.

@akinyiv akinyiv force-pushed the qr-code-component-challenge branch from ae74efd to 50b31a2 Compare January 31, 2024 11:18
@akinyiv akinyiv force-pushed the qr-code-component-challenge branch from 50b31a2 to 2f5528c Compare January 31, 2024 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@almirsarajcic almirsarajcic almirsarajcic approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@akinyiv @almirsarajcic