Fix code style issues

lib/phx_tools_web/plugs/curl_detector.ex

@@ -27,9 +27,8 @@ defmodule PhxToolsWeb.CurlDetector do
     end
   end
 
-  defp request_sent_from_curl?(user_agent) do
-    user_agent && String.starts_with?(user_agent, "curl")
-  end
+  defp request_sent_from_curl?(nil), do: false
+  defp request_sent_from_curl?(user_agent), do: String.starts_with?(user_agent, "curl")
 
   defp script_content do
     :phx_tools

lib/phx_tools_web/router.ex

@@ -10,14 +10,14 @@ defmodule PhxToolsWeb.Router do
     plug :put_secure_browser_headers
   end
 
-  pipeline :system_detector do
-    plug PhxToolsWeb.SystemDetector
-  end
-
   pipeline :curl_detector do
     plug PhxToolsWeb.CurlDetector
   end
 
+  pipeline :system_detector do
+    plug PhxToolsWeb.SystemDetector
+  end
+
   scope "/", PhxToolsWeb do
     pipe_through [:browser, :curl_detector, :system_detector]
 

test/phx_tools_web/plugs/curl_detector_test.exs

@@ -1,10 +1,10 @@
 defmodule PhxToolsWeb.CurlDetectorTest do
   use PhxToolsWeb.ConnCase, async: true
 
-  @script_content File.read!("test/support/script.sh")
+  @script_content "Welcome to the phx.tools shell script"
 
   describe "call/2" do
-    test "returns script content for requests with curl User-Agent on root path", %{conn: conn} do
+    test "responds with script content for requests sent from curl", %{conn: conn} do
       conn =
         conn
         |> put_req_header("user-agent", "curl/7.68.0")
@@ -14,17 +14,18 @@ defmodule PhxToolsWeb.CurlDetectorTest do
       assert String.contains?(conn.resp_body, @script_content)
     end
 
-    test "returns script content for /macOS.sh regardless of User-Agent,", %{conn: conn} do
+    test "responds with website content for requests not sent from curl", %{conn: conn} do
       conn =
         conn
         |> put_req_header("user-agent", "Mozilla/5.0")
-        |> get("/macOS.sh")
+        |> get("/")
 
       assert conn.status == 200
-      assert String.contains?(conn.resp_body, @script_content)
+      refute String.contains?(conn.resp_body, @script_content)
+      assert String.contains?(conn.resp_body, "<html")
     end
 
-    test "returns script content for /Linux.sh regardless of User-Agent,", %{conn: conn} do
+    test "responds with the script for /Linux.sh regardless of User-Agent", %{conn: conn} do
       conn =
         conn
         |> put_req_header("user-agent", "Mozilla/5.0")
@@ -33,5 +34,15 @@ defmodule PhxToolsWeb.CurlDetectorTest do
       assert conn.status == 200
       assert String.contains?(conn.resp_body, @script_content)
     end
+
+    test "responds with the script for /macOS.sh regardless of User-Agent", %{conn: conn} do
+      conn =
+        conn
+        |> put_req_header("user-agent", "Mozilla/5.0")
+        |> get("/macOS.sh")
+
+      assert conn.status == 200
+      assert String.contains?(conn.resp_body, @script_content)
+    end
   end
 end