Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't pull fsLayers with public GCR image #83

Closed
witten opened this issue Mar 2, 2018 · 3 comments
Closed

Can't pull fsLayers with public GCR image #83

witten opened this issue Mar 2, 2018 · 3 comments
Labels

Comments

@witten
Copy link

witten commented Mar 2, 2018

I've deployed Clair into a Kubernetes cluster from the released quay.io/coreos/clair:v2.0.1 Docker image. I'm trying to use Klar 2.0.1 to scan a public image hosted on gcr.io, Google's container registry. But when I do that, I'm getting the Can't pull fsLayers error:

Here's the command I'm running:

CLAIR_ADDR=http://localhost:6060 ./klar-2.0.1-linux-amd64 gcr.io/google_containers/addon-resizer:1.0

I get this error for any public gcr.io image, while images hosted elsewhere scan just fine. Note that I'm not running any of this on GCP and I'm not using a private image, so I'm not authenticating with the instructions here: https://github.com/optiopay/klar#google-gcr-support

@hashmap
Copy link
Contributor

hashmap commented Mar 6, 2018

GCR supports only docker manifest V1, we somehow dropped support of V1, I've fixed this regression, sending a patch. Here is the reason:
Manifest with tag '1.0' has media type 'application/vnd.docker.distribution.manifest.v1+prettyjws', but client accepts 'application/vnd.docker.distribution.manifest.v2+json

@hashmap hashmap added the bug label Mar 6, 2018
hashmap pushed a commit that referenced this issue Mar 6, 2018
* JSON output invalid #84
* Can't pull fsLayers with public GCR image #83
@hashmap
Copy link
Contributor

hashmap commented Mar 12, 2018

Fixed in 2.0.2

@hashmap hashmap closed this as completed Mar 12, 2018
@witten
Copy link
Author

witten commented Mar 13, 2018

Awesome, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants