[GR-57608] Support --enable-native-access hosted option in native image #10076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
graalvmbot
force-pushed
the
je/svm-adopt-JDK-8331671-master
branch
5 times, most recently
from
830a611 to
ed86994
Compare
graalvmbot
force-pushed
the
je/svm-adopt-JDK-8331671-master
branch
from
ed86994 to
646135b
Compare
graalvmbot
changed the title
No need to allow native access to the application modules in the driver. They will not be loaded on the boot module layer, so specifying them there has no effect anyways.
graalvmbot
force-pushed
the
je/svm-adopt-JDK-8331671-master
branch
from
646135b to
68c0f82
Compare
graalvmbot
force-pushed
the
je/svm-adopt-JDK-8331671-master
branch
from
e598c0c to
b7a35bc
Compare
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for the
--enable-native-accesshosted option in the context of JEP 472: Prepare to Restrict the Use of JNI. The modules specified by this flags will be allowed to perform native access at run time. Note that similar to Hotspot, this flag only applied to the boot layer.This change aligns the native access checks in native image to those in the JDK as outline in JEP 472.
Implementation Notes
To allow constant folding of native access checks at build time, the following optimizations are needed:
DynamicHub#modulewith@Stable. This now matches theClass@moduledefinition.Module.EnableNativeAccess#isNativeAccessEnabledconstant folds ifModule#enableNativeAccessfield istrue. This "reimplements" the@Stablefield optimization forModule#enablenativeAccess, which does not trigger because the field is only accessed viaUnsafe.@AliasforModule.layerto make it non-final. The actual run-time value is set via reflection inModuleLayerFeatureUtils#patchModuleLayerField, which is called after analysis. Thus, we cannot leave itfinal, because the analysis might otherwise constant-fold the initialnullvalue.