Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing metadata for hibernate-core #496

Merged
merged 2 commits into from
Jul 24, 2024
Merged

Add missing metadata for hibernate-core #496

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
36ec08e
Add missing hints for hibernate-orm types referenced from ValueGenera…
christophstrobl May 21, 2024
b0dcfc5
Back port hints to metadata for hibernate 6.2
christophstrobl May 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 40 additions & 0 deletions metadata/org.hibernate.orm/hibernate-core/6.2.0.Final/reflect-config.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -453,6 +453,46 @@
"name":"org.hibernate.event.spi.EventType",
"allDeclaredFields":true
},
{
"condition":{"typeReachable":"org.hibernate.id.factory.internal.StandardIdentifierGeneratorFactory"},
"name":"org.hibernate.generator.internal.CurrentTimestampGeneration",
"queryAllDeclaredConstructors":true,
"methods":[
{"name":"<init>","parameterTypes":["org.hibernate.annotations.CreationTimestamp","java.lang.reflect.Member","org.hibernate.generator.GeneratorCreationContext"] },
{"name":"<init>","parameterTypes":["org.hibernate.annotations.CurrentTimestamp","java.lang.reflect.Member","org.hibernate.generator.GeneratorCreationContext"] },
{"name":"<init>","parameterTypes":["org.hibernate.annotations.UpdateTimestamp","java.lang.reflect.Member","org.hibernate.generator.GeneratorCreationContext"] }
]
},
{
"condition":{"typeReachable":"org.hibernate.id.factory.internal.StandardIdentifierGeneratorFactory"},
"name":"org.hibernate.generator.internal.GeneratedAlwaysGeneration",
"queryAllDeclaredConstructors":true,
"methods":[{"name":"<init>","parameterTypes":[] }]
},
{
"condition":{"typeReachable":"org.hibernate.id.factory.internal.StandardIdentifierGeneratorFactory"},
"name":"org.hibernate.generator.internal.GeneratedGeneration",
"queryAllDeclaredConstructors":true,
"methods":[
{"name":"<init>","parameterTypes":["org.hibernate.annotations.Generated"] },
{"name":"<init>","parameterTypes":["org.hibernate.annotations.GenerationTime"] }
]
},
{
"condition":{"typeReachable":"org.hibernate.id.factory.internal.StandardIdentifierGeneratorFactory"},
"name":"org.hibernate.generator.internal.SourceGeneration",
"queryAllDeclaredConstructors":true,
"methods":[
{"name":"<init>","parameterTypes":["org.hibernate.annotations.Source","java.lang.reflect.Member","org.hibernate.generator.GeneratorCreationContext"] },
{"name":"<init>","parameterTypes":["org.hibernate.annotations.SourceType","java.lang.Class","org.hibernate.generator.GeneratorCreationContext"] }
]
},
{
"condition":{"typeReachable":"org.hibernate.id.factory.internal.StandardIdentifierGeneratorFactory"},
"name":"org.hibernate.generator.internal.TenantIdGeneration",
"queryAllDeclaredConstructors":true,
"methods":[{"name":"<init>","parameterTypes":["org.hibernate.annotations.TenantId","java.lang.reflect.Member","org.hibernate.generator.GeneratorCreationContext"] }]
},
{
"condition":{"typeReachable":"org.hibernate.id.factory.internal.StandardIdentifierGeneratorFactory"},
"name":"org.hibernate.id.Assigned",
Expand Down
40 changes: 40 additions & 0 deletions metadata/org.hibernate.orm/hibernate-core/6.5.0.Final/reflect-config.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -518,6 +518,46 @@
"name":"org.hibernate.event.spi.EventType",
"allDeclaredFields":true
},
{
"condition":{"typeReachable":"org.hibernate.id.factory.internal.StandardIdentifierGeneratorFactory"},
"name":"org.hibernate.generator.internal.CurrentTimestampGeneration",
"queryAllDeclaredConstructors":true,
"methods":[
{"name":"<init>","parameterTypes":["org.hibernate.annotations.CreationTimestamp","java.lang.reflect.Member","org.hibernate.generator.GeneratorCreationContext"] },
{"name":"<init>","parameterTypes":["org.hibernate.annotations.CurrentTimestamp","java.lang.reflect.Member","org.hibernate.generator.GeneratorCreationContext"] },
{"name":"<init>","parameterTypes":["org.hibernate.annotations.UpdateTimestamp","java.lang.reflect.Member","org.hibernate.generator.GeneratorCreationContext"] }
]
},
{
"condition":{"typeReachable":"org.hibernate.id.factory.internal.StandardIdentifierGeneratorFactory"},
"name":"org.hibernate.generator.internal.GeneratedAlwaysGeneration",
"queryAllDeclaredConstructors":true,
"methods":[{"name":"<init>","parameterTypes":[] }]
},
{
"condition":{"typeReachable":"org.hibernate.id.factory.internal.StandardIdentifierGeneratorFactory"},
"name":"org.hibernate.generator.internal.GeneratedGeneration",
"queryAllDeclaredConstructors":true,
"methods":[
{"name":"<init>","parameterTypes":["org.hibernate.annotations.Generated"] },
{"name":"<init>","parameterTypes":["org.hibernate.annotations.GenerationTime"] }
]
},
{
"condition":{"typeReachable":"org.hibernate.id.factory.internal.StandardIdentifierGeneratorFactory"},
"name":"org.hibernate.generator.internal.SourceGeneration",
"queryAllDeclaredConstructors":true,
"methods":[
{"name":"<init>","parameterTypes":["org.hibernate.annotations.Source","java.lang.reflect.Member","org.hibernate.generator.GeneratorCreationContext"] },
{"name":"<init>","parameterTypes":["org.hibernate.annotations.SourceType","java.lang.Class","org.hibernate.generator.GeneratorCreationContext"] }
]
},
{
"condition":{"typeReachable":"org.hibernate.id.factory.internal.StandardIdentifierGeneratorFactory"},
"name":"org.hibernate.generator.internal.TenantIdGeneration",
"queryAllDeclaredConstructors":true,
"methods":[{"name":"<init>","parameterTypes":["org.hibernate.annotations.TenantId","java.lang.reflect.Member","org.hibernate.generator.GeneratorCreationContext"] }]
},
{
"condition":{"typeReachable":"org.hibernate.id.factory.internal.StandardIdentifierGeneratorFactory"},
"name":"org.hibernate.id.Assigned",
Expand Down
21 changes: 21 additions & 0 deletions ...e/6.5.0.Final/src/test/java/org_hibernate_orm/hibernate_core/IdentifierGeneratorTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,11 +26,32 @@ public class IdentifierGeneratorTest {
org.hibernate.id.ForeignGenerator.class
};

private static final Class[] VALUE_GENERATION_TYPE_GENERATORS_FROM_ANNOTATIONS = new Class[]{
org.hibernate.generator.internal.CurrentTimestampGeneration.class,
org.hibernate.generator.internal.GeneratedAlwaysGeneration.class,
org.hibernate.generator.internal.GeneratedGeneration.class,
org.hibernate.generator.internal.SourceGeneration.class,
org.hibernate.generator.internal.TenantIdGeneration.class
};

@Test
public void testIdentifierGenerators() throws Exception {
for (Class clazz : identifierGenerators) {
Constructor constructor = clazz.getConstructor();
assertThat(constructor).isNotNull();
}
}

/**
* {@link org.hibernate.annotations.ValueGenerationType#generatedBy()} may hold types reflectively instantiated.
* This uses a list of those to make sure hints are present.
*/
@Test
public void testValueGenerationTypes() throws Exception {
for (Class clazz : VALUE_GENERATION_TYPE_GENERATORS_FROM_ANNOTATIONS) {
for (Constructor<?> ctor : clazz.getDeclaredConstructors()) {
assertThat(clazz.getConstructor(ctor.getParameterTypes())).isEqualTo(ctor);
}
}
}
}
Loading