Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Working Volume provisioner E2E tests #260

Merged
merged 8 commits into from
Oct 29, 2018
Merged

Working Volume provisioner E2E tests #260

merged 8 commits into from
Oct 29, 2018

Conversation

prydie
Copy link
Contributor

@prydie prydie commented Oct 26, 2018

Currently doesn't deploy the flexvolume driver (running against manually deployed version atm).

Additionally

  • Share cloud-provider config between projects (validation and client construction still needs cleaning up)

@prydie prydie requested a review from owainlewis October 26, 2018 17:03
@owainlewis owainlewis self-assigned this Oct 29, 2018
@harveylowndes
Copy link
Contributor

LGTM 👍

Copy link
Member

@owainlewis owainlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. Nice to see auth config cleanup done.

@owainlewis owainlewis merged commit 027cd05 into master Oct 29, 2018
@owainlewis owainlewis deleted the ap/vp-e2e-ci branch October 29, 2018 11:40
ayushverma14 pushed a commit to ayushverma14/oci-cloud-controller-manager that referenced this pull request Jul 18, 2022
* Run VP E2E tests in CI
* Fix FSS not found bug
* Use mount target in AD2 in FSS E2E
* Use cloud-provider config in volume provisioner
* Don't use go's -i flag anymore. See: golang/go#27285
* Use cloud-provider config in flexvolume driver
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants