Avoid raising an exception if an error message is not correctly UTF-8

encoded.
oracle · Jul 19, 2024 · 023092c · 023092c
1 parent a95def8
commit 023092c
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/doc/src/release_notes.rst b/doc/src/release_notes.rst
@@ -37,6 +37,8 @@ Thick Mode Changes
 
 #)  Eliminated memory leak when dequeing messages with JSON payloads
     (`issue 346 <https://github.com/oracle/python-oracledb/issues/346>`__).
+#)  An exception is now avoided if an error message is not correctly UTF-8
+    encoded by the database.
 
 Common Changes
 ++++++++++++++

diff --git a/src/oracledb/impl/thick/utils.pyx b/src/oracledb/impl/thick/utils.pyx
@@ -432,8 +432,8 @@ cdef object _create_new_from_info(dpiErrorInfo *error_info):
     """
     cdef bytes msg_bytes = error_info.message[:error_info.messageLength]
     context = "%s: %s" % (error_info.fnName, error_info.action)
-    return errors._Error(msg_bytes.decode(), context, code=error_info.code,
-                         offset=error_info.offset,
+    return errors._Error(msg_bytes.decode("utf-8", "replace"), context,
+                         code=error_info.code, offset=error_info.offset,
                          isrecoverable=error_info.isRecoverable,
                          iswarning=error_info.isWarning)