-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gaussian Mixture Model implementation #369
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…determinant, SparseVector.subtract.
oracle-contributor-agreement
bot
added
the
OCA Verified
All contributors have signed the Oracle Contributor Agreement.
label
May 20, 2024
Math/src/main/java/org/tribuo/math/distributions/MultivariateNormalDistribution.java
Show resolved
Hide resolved
Math/src/main/java/org/tribuo/math/distributions/MultivariateNormalDistribution.java
Show resolved
Hide resolved
Clustering/GMM/src/main/java/org/tribuo/clustering/gmm/GaussianMixtureModel.java
Show resolved
Hide resolved
JackSullivan
requested changes
Dec 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good apart from the above nitpicks
I've updated this PR after the review. |
JackSullivan
approved these changes
Dec 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
Craigacp
added a commit
that referenced
this pull request
Dec 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
OCA Verified
All contributors have signed the Oracle Contributor Agreement.
Oracle employee
This PR is from an Oracle employee
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a Gaussian Mixture Model clustering implementation with spherical, diagonal and full covariance structure using Expectation Maximisation. Also adds a mixture distribution to the RNG library to allow sampling from a user constructed gaussian mixture model (as opposed to one fit to a data distribution).
It also contains new Math functions necessary to implement the GMM efficiently, some updates for K-Means to modernise it a little bit, and some cleanups to the main pom file.
There are a few important fixes to the Math package in here as well, determinants for matrix factorizations were incorrectly computed, and the subtract function on SparseVector was incorrect.
Motivation
GMMs are a useful clustering algorithm. Fixes #359.
Paper reference
Hastie, T., Tibshirani, R., Friedman, J. H., & Friedman, J. H. (2009). The Elements of Statistical Learning: Data Mining, Inference, and Prediction, Second Edition.