Skip to content
This repository has been archived by the owner on Apr 7, 2024. It is now read-only.

Support Credential() method #33

Closed
Wwwsylvia opened this issue Mar 28, 2023 · 0 comments · Fixed by #45
Closed

Support Credential() method #33

Wwwsylvia opened this issue Mar 28, 2023 · 0 comments · Fixed by #45
Assignees
@wangxiaoxuan273
Labels
enhancement New feature or request
Milestone
v0.1.0

Comments

@Wwwsylvia
Copy link
Member

Wwwsylvia commented Mar 28, 2023 •
edited
Loading

The method should return a Credential() function that can be used by auth.Client of oras-go v2.

Proposed API:

package credentials

func Credential(store Store) func(context.Context, string) (auth.Credential, error) {
}

Design discussion: #18
@Wwwsylvia Wwwsylvia added the enhancement New feature or request label Mar 28, 2023
@Wwwsylvia Wwwsylvia added this to the v0.1.0 milestone Mar 28, 2023
@wangxiaoxuan273 wangxiaoxuan273 mentioned this issue Apr 7, 2023
Merged
shizhMSFT pushed a commit that referenced this issue Apr 20, 2023
@wangxiaoxuan273
feat: support credential function (#45)
9d0706f 
Resolves #33

Signed-off-by: wangxiaoxuan273 <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@wangxiaoxuan273 wangxiaoxuan273

Labels
enhancement New feature or request
Projects
No open projects
ORAS Project Board-2023
Status: Done
Milestone
v0.1.0
Development

Successfully merging a pull request may close this issue.

feat: support credential function
2 participants
@Wwwsylvia @wangxiaoxuan273