fix(client): Return the digest header for partial responses #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In oras-project#163 it was pointed out that we can't use validating streams for partial responses, which makes complete sense. Because of this, we need to pass back the digest header for use in validation once a partial download is complete Signed-off-by: Taylor Thomas <[email protected]>
flavio
approved these changes
Oct 7, 2024
flavio
added a commit
to flavio/rust-oci-client
that referenced
this pull request
Oct 7, 2024
== What's Changed * client: add support to set https_proxy/no_proxy for client by @Xynnn007 in oras-project#160 * chore(deps): Update testcontainers requirement from 0.20 to 0.22 by @dependabot in oras-project#161 * Docs.rs badge, update crate name. by @bddap in oras-project#166 * chore(deps): Bump actions/checkout from 4.1.7 to 4.2.0 by @dependabot in oras-project#170 * chore(deps): Update testcontainers requirement from 0.22 to 0.23 by @dependabot in oras-project#169 * chore(deps): Update rstest requirement from 0.22.0 to 0.23.0 by @dependabot in oras-project#168 * Allow doing start-end RANGE requests against blobs by @thundergolfer in oras-project#163 * fix(client): Return the digest header for partial responses by @thomastaylor312 in oras-project#171 * remove reference by @flavio in oras-project#164 == New Contributors * @bddap made their first contribution in oras-project#166 * @thundergolfer made their first contribution in oras-project#163 **Full Changelog**: oras-project/rust-oci-client@v0.12.1...v0.13.0 Signed-off-by: Flavio Castelli <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #163 it was pointed out that we can't use validating streams for partial responses, which makes complete sense. Because of this, we need to pass back the digest header for use in validation once a partial download is complete.
This also fixes a few clippy errors I saw