fix: s390x architecture is not handled #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkulke
force-pushed
the
mkulke/fix-s390x-arch-parsing
branch
from
c33c6d2 to
d9c47f1
Compare
|
Thanks @mkulke for the contribution. Currently you may use /lgtm |
shizhMSFT
force-pushed
the
mkulke/fix-s390x-arch-parsing
branch
from
d9c47f1 to
52cf968
Compare
The project releases s390x binaries (64bit), but not s390 (31bit). Node reports a s390x runner correctly as "s390x", so instllations will fail on this platform. https://nodejs.org/api/os.html#osarch Hence the s390 arch case has been changed to the s390x. Signed-off-by: Magnus Kulke <[email protected]>
shizhMSFT
force-pushed
the
mkulke/fix-s390x-arch-parsing
branch
from
52cf968 to
05cb9c1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The project releases s390x binaries (64bit), but not s390 (31bit). Node reports a s390x runner correctly as "s390x", so instllations will fail on this platform.
https://nodejs.org/api/os.html#osarch
Hence the s390 arch case has been changed to the s390x.