Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] agent short form #1982

Merged
merged 3 commits into from
Nov 10, 2022
Merged

[FIX] agent short form #1982

merged 3 commits into from
Nov 10, 2022

Conversation

etaques
Copy link
Contributor

@etaques etaques commented Nov 7, 2022

This PR fixes agent short form:

Command used to test:

docker run -d --restart=always --net=host -v /home/user/Downloads/:/usr/local/orb/ -e ORB_CLOUD_MQTT_ID=6e72a741-f148-4c6d-ab47-18296ad3055d -e ORB_CLOUD_MQTT_CHANNEL_ID=6e72a741-f148-4c6d-ab47-18296ad3055d -e ORB_CLOUD_MQTT_KEY=6e72a741-f148-4c6d-ab47-18296ad3055d ns1labs/orb-agent:0.21.0-f8977f7c run -c /usr/local/orb/agent.yaml

image

@etaques etaques requested a review from weyrick November 7, 2022 20:40
@weyrick
Copy link
Member

weyrick commented Nov 8, 2022

Has this been tested with other scenarios like with a config file, or with these other options like when PKTVISOR_SFLOW=true?

@etaques
Copy link
Contributor Author

etaques commented Nov 9, 2022

Has this been tested with other scenarios like with a config file, or with these other options like when PKTVISOR_SFLOW=true?

Yes, Now is working fine. I did all tests! ;)

@etaques etaques requested a review from lpegoraro November 9, 2022 17:35
Copy link
Contributor

@lpegoraro lpegoraro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@etaques etaques merged commit 3adda5e into develop Nov 10, 2022
@etaques etaques deleted the etaques-patch-1 branch November 10, 2022 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants